From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com, matthew@wil.cx, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/6] Extend completions to provide XFS object flush requirements
Date: Thu, 26 Jun 2008 23:18:29 +1000 [thread overview]
Message-ID: <20080626131829.GT29319@disturbed> (raw)
In-Reply-To: <20080626130700.GA24325@infradead.org>
On Thu, Jun 26, 2008 at 09:07:00AM -0400, Christoph Hellwig wrote:
> On Thu, Jun 26, 2008 at 09:21:33PM +1000, Dave Chinner wrote:
> > Ok, so that involves exactly what? A new header file, a new API name
> > (ideas anyone?) and kerneldoc comments?
>
> Yes, probably just a new header with properly documented functions.
> Thew two non-trivial ones you added should probably not be inlines,
> btw.
Yeah, they grew a little bigger than expected...
> flush_lock_init/flush_lock/flush_trylock/flush_done/flush_is_locked?
Ok, I was thinking along those lines. I'll redo the patch series
using that interface tomorrow.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2008-06-26 13:17 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-26 4:41 [PATCH 0/6] Remove most users of semaphores from XFS Dave Chinner
2008-06-26 4:41 ` [PATCH 1/6] Extend completions to provide XFS object flush requirements Dave Chinner
2008-06-26 7:46 ` Christoph Hellwig
2008-06-26 11:21 ` Dave Chinner
2008-06-26 13:07 ` Christoph Hellwig
2008-06-26 13:18 ` Dave Chinner [this message]
2008-06-26 11:26 ` Matthew Wilcox
2008-06-26 11:32 ` Dave Chinner
2008-06-26 11:42 ` Matthew Wilcox
2008-06-26 12:21 ` Dave Chinner
2008-06-26 12:40 ` Matthew Wilcox
2008-06-26 12:49 ` Christoph Hellwig
2008-06-26 13:02 ` Dave Chinner
2008-06-26 20:33 ` Daniel Walker
2008-06-27 1:52 ` Dave Chinner
2008-06-27 2:24 ` Matthew Wilcox
2008-06-27 3:26 ` Daniel Walker
2008-06-27 9:15 ` Christoph Hellwig
2008-06-27 14:37 ` Daniel Walker
2008-06-26 4:41 ` [PATCH 2/6] Replace inode flush semaphore with a completion Dave Chinner
2008-06-27 2:30 ` Matthew Wilcox
2008-06-27 4:13 ` Dave Chinner
2008-06-26 4:41 ` [PATCH 3/6] Replace dquot " Dave Chinner
2008-06-26 4:41 ` [PATCH 4/6] Replace the XFS buf iodone " Dave Chinner
2008-06-26 7:41 ` Christoph Hellwig
2008-06-26 4:41 ` [PATCH 5/6] Remove the sema_t from XFS Dave Chinner
2008-06-26 4:41 ` [PATCH 6/6] Clean up stale references to semaphores Dave Chinner
2008-06-26 7:47 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080626131829.GT29319@disturbed \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.