From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KBsLE-0003zu-31 for mharc-grub-devel@gnu.org; Thu, 26 Jun 2008 10:20:52 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KBsLB-0003z4-O1 for grub-devel@gnu.org; Thu, 26 Jun 2008 10:20:49 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KBsLA-0003xj-2Q for grub-devel@gnu.org; Thu, 26 Jun 2008 10:20:49 -0400 Received: from [199.232.76.173] (port=52041 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KBsL9-0003xU-P6 for grub-devel@gnu.org; Thu, 26 Jun 2008 10:20:47 -0400 Received: from aybabtu.com ([69.60.117.155]:54135) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KBsL8-0000eX-Rs for grub-devel@gnu.org; Thu, 26 Jun 2008 10:20:47 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.69) (envelope-from ) id 1KBsHr-0002Ox-9E for grub-devel@gnu.org; Thu, 26 Jun 2008 16:17:23 +0200 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1KBsKY-000270-GF for grub-devel@gnu.org; Thu, 26 Jun 2008 16:20:10 +0200 Date: Thu, 26 Jun 2008 16:20:10 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20080626142010.GD7511@thorin> References: <1214430514.11716.19.camel@dv> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1214430514.11716.19.camel@dv> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: Failure to embed core.img is fatal now X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Jun 2008 14:20:50 -0000 On Wed, Jun 25, 2008 at 05:48:34PM -0400, Pavel Roskin wrote: > > I'm also surprised that the code alternately uses dir and > DEFAULT_DIRECTORY to calculate core_path. core_path is calculated 3 > times in one function! If dir and DEFAULT_DIRECTORY are used correctly, > I suggest that two different variables are used for what is now called > core_path. Might be a remnant from when grub-setup mangled prefix? I recently moved this off grub-setup and into grub-install/grub-mkimage so that core.img had the right prefix regardless on whether it was being loaded directly by a multiboot loader or via grub-setup. Or maybe I'm completely out of context here. In any case, please take into account that modifications done to core.img by grub-setup have no effect if core.img is being loaded directly. -- Robert Millan I know my rights; I want my phone call! What good is a phone call… if you are unable to speak? (as seen on /.)