From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Daniel P. Berrange" Subject: Re: [PATCH] xend: open qemu-dm log files in append mode Date: Thu, 26 Jun 2008 15:51:00 +0100 Message-ID: <20080626145100.GO20952@redhat.com> References: <486323E3.3000407@ab.jp.nec.com> <18531.44047.726185.484243@mariner.uk.xensource.com> Reply-To: "Daniel P. Berrange" Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <18531.44047.726185.484243@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Ian Jackson Cc: Yuji Shimada , xen-devel@lists.xensource.com, Yosuke Iwamatsu List-Id: xen-devel@lists.xenproject.org On Thu, Jun 26, 2008 at 03:47:43PM +0100, Ian Jackson wrote: > Yosuke Iwamatsu writes ("[Xen-devel] [PATCH] xend: open qemu-dm log files in append mode"): > > qemu-dm log files would be easily overwritten if domains reboot several > > times. With this patch, a single qemu-dm log file is used per domain and > > log messages will be continuously appended to it. > > Surely it would be better to rotate the logs rather than just > appending. Having each run in a separate file makes finding the > relevant log entries much easier. XenD already does rotate the qemu logs unless the code I added todo that has since been removed, so if the domain reboots we should keep at least one historic log Regards, Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|