From: "J. Bruce Fields" <bfields@fieldses.org>
To: Olga Kornievskaia <aglo@citi.umich.edu>
Cc: linux-nfs@vger.kernel.org, Neil Brown <neilb@suse.de>
Subject: Re: [PATCH] NFSD: fix use of setsockopt
Date: Thu, 26 Jun 2008 13:14:12 -0400 [thread overview]
Message-ID: <20080626171412.GC6961@fieldses.org> (raw)
In-Reply-To: <4862AE1F.5050902@citi.umich.edu>
On Wed, Jun 25, 2008 at 04:44:15PM -0400, Olga Kornievskaia wrote:
> Looking at the kernel code, when setsockopt() is called on a UDP socket
> to set send/receive buffer for UPD the code will not do anything:
> udp_setsockopt() and udp_lib_setsockopt() will return -ENOPROTOOPT.
> However, we bypass the call to setsockopt() and instead set the buffer
> sizes directly. From what I understand sk_sndbuf/sk_rcvbuf are not used
> by the UDP code. We are setting the fields that are never used.
>
> Then perhaps we can remove calls to svc_sock_setbufsize() from
> svc_udp_init() and svc_udp_recvfrom()?
Assuming you're correct about udp not using those fields (haven't
checked myself)--yes, that'd be great.
--b.
next prev parent reply other threads:[~2008-06-26 17:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-19 13:33 [PATCH] NFSD: fix use of setsockopt Olga Kornievskaia
2008-06-25 0:50 ` Dean Hildebrand
2008-06-25 19:40 ` J. Bruce Fields
2008-06-25 19:37 ` J. Bruce Fields
2008-06-25 20:44 ` Olga Kornievskaia
2008-06-26 17:14 ` J. Bruce Fields [this message]
2008-06-26 17:59 ` Sm-notify Laurenz, Dirk
[not found] ` <FC3FA7C4E1CA2348B5579A68B24556E9DA4AF2946C-KofoAzQUpSBAuK1PVaBULA@public.gmane.org>
2008-06-27 2:22 ` Sm-notify NeilBrown
[not found] ` <46260.192.168.1.70.1214533375.squirrel-eq65iwfR9nKIECXXMXunQA@public.gmane.org>
2008-06-27 6:58 ` Sm-notify Oeltze, Benjamin
2008-06-27 23:44 ` Sm-notify Neil Brown
[not found] ` <18533.31573.855657.391140-wvvUuzkyo1EYVZTmpyfIwg@public.gmane.org>
2008-06-28 7:38 ` Sm-notify Laurenz, Dirk
2008-06-28 10:33 ` Sm-notify Neil Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080626171412.GC6961@fieldses.org \
--to=bfields@fieldses.org \
--cc=aglo@citi.umich.edu \
--cc=linux-nfs@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.