All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ivo van Doorn <ivdoorn@gmail.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: John Linville <linville@tuxdriver.com>,
	linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] mac80211: make workqueue freezable
Date: Thu, 26 Jun 2008 20:14:27 +0200	[thread overview]
Message-ID: <200806262014.27907.IvDoorn@gmail.com> (raw)
In-Reply-To: <1214503196.3783.13.camel@johannes.berg>

On Thursday 26 June 2008, Johannes Berg wrote:
> This patch makes the mac80211 workqueue freezable making it
> interact a bit better with system suspend and not try to ping
> the AP while the hardware is down.
>=20
> This doesn't really help with implementing proper suspend in
> any way but makes some bad things trigger less.
>=20
> Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
> ---
> I'm not sure whether we should put this into 2.6.26 or not, while it
> might help a bit it doesn't really do much over what the tx bugs find=
er
> already does except avoid sending out the packets that froze b43 in t=
he
> first place...
>=20
> Ivo, you might consider using =EF=BB=BFcreate_freezeable_workqueue fo=
r your
> rt2x00 patch though.

Will do. Thanks for the tip.

Ivo

>  net/mac80211/main.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> --- everything.orig/net/mac80211/main.c	2008-06-26 18:21:14.000000000=
 +0200
> +++ everything/net/mac80211/main.c	2008-06-26 18:21:16.000000000 +020=
0
> @@ -1774,7 +1774,7 @@ int ieee80211_register_hw(struct ieee802
>  	list_add_tail(&sdata->list, &local->interfaces);
> =20
>  	name =3D wiphy_dev(local->hw.wiphy)->driver->name;
> -	local->hw.workqueue =3D create_singlethread_workqueue(name);
> +	local->hw.workqueue =3D create_freezeable_workqueue(name);
>  	if (!local->hw.workqueue) {
>  		result =3D -ENOMEM;
>  		goto fail_workqueue;
>=20
>=20
>=20


--
To unsubscribe from this list: send the line "unsubscribe linux-wireles=
s" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2008-06-26 18:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-26 17:59 [PATCH] mac80211: make workqueue freezable Johannes Berg
2008-06-26 18:14 ` Ivo van Doorn [this message]
2008-06-26 18:21   ` Ivo van Doorn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200806262014.27907.IvDoorn@gmail.com \
    --to=ivdoorn@gmail.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.