All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heiko Carstens <heiko.carstens@de.ibm.com>
To: Johannes Weiner <hannes@saeurebad.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org
Subject: Re: [PATCH 02/20] mm: generic show_mem()
Date: Fri, 27 Jun 2008 16:43:30 +0200	[thread overview]
Message-ID: <20080627144329.GA7634@osiris.ibm.com> (raw)
In-Reply-To: <20080627120048.059732179@saeurebad.de>

> +#ifdef CONFIG_HAVE_GENERIC_SHOW_MEM
> +void show_mem(void)
> +{
> +	pg_data_t *pgdat;
> +	int total = 0, reserved = 0, shared = 0, nonshared = 0, highmem = 0;

All of these should be unsigned long. Might overflow on very large
configurations otherwise.

  reply	other threads:[~2008-06-27 14:44 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-27 11:53 [PATCH 00/20] mm: generic show_mem() v4 Johannes Weiner
2008-06-27 11:53 ` [PATCH 01/20] mm: print swapcache page count in show_swap_cache_info() Johannes Weiner
2008-06-27 11:53 ` [PATCH 02/20] mm: generic show_mem() Johannes Weiner
2008-06-27 14:43   ` Heiko Carstens [this message]
2008-06-27 21:17     ` [PATCH 02/20 fixed] " Johannes Weiner
2008-06-28  4:22   ` [PATCH 02/20] " Paul Mundt
2008-06-28 10:25     ` Johannes Weiner
2008-06-28 17:51       ` Paul Mundt
2008-06-27 11:53 ` [PATCH 03/20] alpha: use " Johannes Weiner
2008-06-27 11:53 ` [PATCH 04/20] avr32: " Johannes Weiner
2008-06-27 11:53 ` [PATCH 05/20] blackfin: " Johannes Weiner
2008-06-27 11:53 ` [PATCH 06/20] cris: " Johannes Weiner
2008-06-27 11:53 ` [PATCH 07/20] frv: " Johannes Weiner
2008-06-27 11:53 ` [PATCH 08/20] m32r: " Johannes Weiner
2008-06-27 11:53 ` [PATCH 09/20] m68k: " Johannes Weiner
2008-06-29  9:17   ` Geert Uytterhoeven
2008-06-27 11:53 ` [PATCH 10/20] m68knommu: " Johannes Weiner
2008-06-27 11:54 ` [PATCH 11/20] mips: " Johannes Weiner
2008-06-27 11:54 ` [PATCH 12/20] h8300: " Johannes Weiner
2008-06-27 11:54 ` [PATCH 13/20] mn10300: " Johannes Weiner
2008-06-27 11:54 ` [PATCH 14/20] powerpc: " Johannes Weiner
2008-07-01  7:27   ` Benjamin Herrenschmidt
2008-06-27 11:54 ` [PATCH 15/20] s390: " Johannes Weiner
2008-06-27 11:54 ` [PATCH 16/20] sh: " Johannes Weiner
2008-06-27 11:54 ` [PATCH 17/20] sparc64: " Johannes Weiner
2008-06-27 22:46   ` David Miller
2008-06-27 11:54 ` [PATCH 18/20] um: " Johannes Weiner
2008-06-27 15:08   ` Jeff Dike
2008-06-27 11:54 ` [PATCH 19/20] x86: " Johannes Weiner
2008-06-27 11:54 ` [PATCH 20/20] xtensa: " Johannes Weiner
2008-07-01  6:55 ` [PATCH 00/20] mm: generic show_mem() v4 Johannes Weiner
2008-07-01  7:25   ` Andrew Morton
2008-07-01  7:54     ` Johannes Weiner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080627144329.GA7634@osiris.ibm.com \
    --to=heiko.carstens@de.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=hannes@saeurebad.de \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.