All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen.hemminger@vyatta.com>
To: David Miller <davem@davemloft.net>
Cc: shemminger@vyatta.com, netdev@vger.kernel.org
Subject: Re: [RFC] RTT metrics scaling
Date: Fri, 27 Jun 2008 22:30:07 -0700	[thread overview]
Message-ID: <20080627223007.02eb6622@speedy> (raw)
In-Reply-To: <20080627.195013.184418536.davem@davemloft.net>

On Fri, 27 Jun 2008 19:50:13 -0700 (PDT)
David Miller <davem@davemloft.net> wrote:

> From: Stephen Hemminger <shemminger@vyatta.com>
> Date: Fri, 20 Jun 2008 16:22:34 -0700
> 
> > Some of the metrics (RTT, RTTVAR and RTAX_RTO_MIN) are stored in kernel
> > units (jiffies) and this leaks out through the netlink API to user space
> > where the units for jiffies are unknown.
> > 
> > This patches changes the kernel to convert to/from milliseconds. This changes
> > the ABI, but milliseconds seemed like the most natural unit for these parameters.
> > 
> > This patch is for comment only, just to show how it would be implemented.
> > I will update it after testing more.
> 
> No real objection.
> 
> But aren't we approaching microsecond RTT's soon? :-) (yes, I know in
> TCP we min clamp at 200ms RTT, but that clamp we probably want to
> remove soon)

We could put in microseconds, but since it is computer off of jiffies (ie clock
ticks), the resolution wouldn't be worth it.


> If you don't think that's worth worrying about, I'll apply this patch.

Hold off it needs more testing.

  reply	other threads:[~2008-06-28  5:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-20 23:22 [RFC] RTT metrics scaling Stephen Hemminger
2008-06-28  2:50 ` David Miller
2008-06-28  5:30   ` Stephen Hemminger [this message]
2008-06-28  8:07     ` David Miller
2008-07-19  3:34 ` [PATCH] tcp: " Stephen Hemminger
2008-07-19  6:02   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080627223007.02eb6622@speedy \
    --to=stephen.hemminger@vyatta.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=shemminger@vyatta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.