Re: grub_strdup() error; or: grub_malloc() zeroes memory?

[Colin D Bennett <colin@gibibit.com>]

[-- Attachment #1: Type: text/plain, Size: 808 bytes --]

On Sat, 28 Jun 2008 18:25:01 +0300
Vesa Jääskeläinen <chaac@nic.fi> wrote:

> Colin D Bennett wrote:
> > It looks like grub_strdup() does not terminate the returned string
> > with a 0 byte.  The only way I could see it working is if
> > grub_malloc() filled the returned memory with zeroes.  Does it?
> > 
> > From kern/misc.c: (circa line 476)
> > 
> >    char *
> >    grub_strdup (const char *s)
> >    {
> >      grub_size_t len;
> >      char *p;
> >      
> >      len = grub_strlen (s) + 1;
> >      p = (char *) grub_malloc (len);
> >      if (! p)
> >        return 0;
> > 
> >      return grub_memcpy (p, s, len);
> >    }
> 
> Zero is copied from source string... notice strlen() + 1.

Doh!
/me smacks his forehead.
Thanks for pointing that out.

Cheers,
Colin

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 197 bytes --]