From: Grant Likely <grant.likely@secretlab.ca>
To: John Rigby <jcrigby@gmail.com>
Cc: linuxppc-dev@ozlabs.org, John Rigby <jrigby@freescale.com>
Subject: Re: [Resend][PATCH 1/8][Version 2] MPC5121 Update MPC5121ADS device tree
Date: Sun, 29 Jun 2008 00:15:33 -0600 [thread overview]
Message-ID: <20080629061533.GL13876@secretlab.ca> (raw)
In-Reply-To: <4b73d43f0806262040s7993dcb7vd8a3d05793ea8a7@mail.gmail.com>
On Thu, Jun 26, 2008 at 09:40:57PM -0600, John Rigby wrote:
> On Thu, Jun 26, 2008 at 7:42 PM, David Gibson <david@gibson.dropbear.id.au> wrote:
> > On Wed, Jun 18, 2008 at 02:24:46PM -0600, John Rigby wrote:
> >> soc@80000000 {
> >> compatible = "fsl,mpc5121-immr";
> >> + device_type = "soc";
> >
> > I realise we still need the unwanted device_type value on the soc in
> > some cases for backwards compatibility, but why are you adding it
> > where it wasn't before..?
> >
> Because get_immrbase in fsl_soc.c does not work without it.
I think I'd rather see get_immrbase() instead then.
g.
next prev parent reply other threads:[~2008-06-29 6:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-18 20:24 [Resend][PATCH 1/8][Version 2] MPC5121 Update MPC5121ADS device tree John Rigby
2008-06-26 7:32 ` Arnd Bergmann
2008-06-27 1:42 ` David Gibson
2008-06-27 3:40 ` John Rigby
2008-06-27 11:22 ` Arnd Bergmann
2008-06-29 6:15 ` Grant Likely [this message]
2008-06-29 7:09 ` Grant Likely
2008-06-29 6:12 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080629061533.GL13876@secretlab.ca \
--to=grant.likely@secretlab.ca \
--cc=jcrigby@gmail.com \
--cc=jrigby@freescale.com \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.