From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KCv4R-0001lv-04 for mharc-grub-devel@gnu.org; Sun, 29 Jun 2008 07:27:51 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KCv4P-0001kx-Em for grub-devel@gnu.org; Sun, 29 Jun 2008 07:27:49 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KCv4O-0001kl-15 for grub-devel@gnu.org; Sun, 29 Jun 2008 07:27:48 -0400 Received: from [199.232.76.173] (port=58052 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KCv4N-0001ki-TF for grub-devel@gnu.org; Sun, 29 Jun 2008 07:27:47 -0400 Received: from aybabtu.com ([69.60.117.155]:56797) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KCv4N-0005R5-IO for grub-devel@gnu.org; Sun, 29 Jun 2008 07:27:47 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.69) (envelope-from ) id 1KCv0s-0000lo-82 for grub-devel@gnu.org; Sun, 29 Jun 2008 13:24:11 +0200 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1KCv3g-0000ea-Lg for grub-devel@gnu.org; Sun, 29 Jun 2008 13:27:04 +0200 Date: Sun, 29 Jun 2008 13:27:04 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20080629112704.GC2347@thorin> References: <1214430514.11716.19.camel@dv> <20080626142010.GD7511@thorin> <1214491693.30044.5.camel@dv> <1214499294.17243.2.camel@dv> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1214499294.17243.2.camel@dv> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: Failure to embed core.img is fatal now X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Jun 2008 11:27:49 -0000 On Thu, Jun 26, 2008 at 12:54:54PM -0400, Pavel Roskin wrote: > + dos_part = grub_cpu_to_le32 (root_dev->disk->partition->index); > + bsd_part = grub_cpu_to_le32 (-1); > [...] > grub_util_info ("dos partition is %d, bsd partition is %d", > - grub_le_to_cpu32 (*install_dos_part), > - grub_le_to_cpu32 (*install_bsd_part)); > + grub_le_to_cpu32 (dos_part), grub_le_to_cpu32 (bsd_part)); You're doing endian conversion twice. -- Robert Millan I know my rights; I want my phone call! What good is a phone call… if you are unable to speak? (as seen on /.)