From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Brownell Subject: Re: [PATCH 2/4] spi: split up spi_new_device() to allow two stage registration. Date: Sun, 29 Jun 2008 21:08:15 -0700 Message-ID: <200806292108.15909.david-b@pacbell.net> References: <20080516193054.28030.35126.stgit@trillian.secretlab.ca> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Cc: linuxppc-dev-mnsaURCQ41sdnm+yROfE0A@public.gmane.org, fabrizio.garetto-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, jonsmirl-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: "Grant Likely" Return-path: In-Reply-To: Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: linux-spi.vger.kernel.org On Friday 23 May 2008, Grant Likely wrote: > Question: =A0spi_alloc_device() (and the original code) does a > spi_master_get() on the spi_master device. =A0Doesn't spi_master_put() > need to be called when the device is discarded? =A0spi_dev_put() doesn't > do that explicitly; is it an implicit operation after a device has > been deregistered from the spi_master? Depends whether or not the add() has been done to hook things into the driver model tree, as I recall. The add() presumes things are properly refcounted. When you make a driver model tree node vanish, its associated refcounts get updated too. - Dave ------------------------------------------------------------------------- Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://sourceforge.net/services/buy/index.php From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp120.sbc.mail.sp1.yahoo.com (smtp120.sbc.mail.sp1.yahoo.com [69.147.64.93]) by ozlabs.org (Postfix) with SMTP id 80280DDF10 for ; Mon, 30 Jun 2008 14:08:18 +1000 (EST) From: David Brownell To: "Grant Likely" Subject: Re: [PATCH 2/4] spi: split up spi_new_device() to allow two stage registration. Date: Sun, 29 Jun 2008 21:08:15 -0700 References: <20080516193054.28030.35126.stgit@trillian.secretlab.ca> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Message-Id: <200806292108.15909.david-b@pacbell.net> Cc: linuxppc-dev@ozlabs.org, fabrizio.garetto@gmail.com, linux-kernel@vger.kernel.org, spi-devel-general@lists.sourceforge.net List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Friday 23 May 2008, Grant Likely wrote: > Question:  spi_alloc_device() (and the original code) does a > spi_master_get() on the spi_master device.  Doesn't spi_master_put() > need to be called when the device is discarded?  spi_dev_put() doesn't > do that explicitly; is it an implicit operation after a device has > been deregistered from the spi_master? Depends whether or not the add() has been done to hook things into the driver model tree, as I recall. The add() presumes things are properly refcounted. When you make a driver model tree node vanish, its associated refcounts get updated too. - Dave From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753651AbYF3EI0 (ORCPT ); Mon, 30 Jun 2008 00:08:26 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750849AbYF3EIS (ORCPT ); Mon, 30 Jun 2008 00:08:18 -0400 Received: from smtp120.sbc.mail.sp1.yahoo.com ([69.147.64.93]:48486 "HELO smtp120.sbc.mail.sp1.yahoo.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1750777AbYF3EIR (ORCPT ); Mon, 30 Jun 2008 00:08:17 -0400 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=s1024; d=pacbell.net; h=Received:X-YMail-OSG:X-Yahoo-Newman-Property:From:To:Subject:Date:User-Agent:Cc:References:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding:Content-Disposition:Message-Id; b=rZthfflQsTIXvnf5yhe9O5voANV/c+vjnU4jLPoFFyODwMlBztBG/N2eI0LPE6HMCOwfKHZ8atISSo4/RWpy5W+5D98JQJJ50tN67uoLueBqez7fIcI7vTY/nuCYekZ5eYaTAx88ys+5nchvNgxCXVYj4RQwr3+1Q0v4rgwmcc8= ; X-YMail-OSG: moVXucMVM1nft_TkUYZZVt104_2RIn5_299TdNAmoxR8X8znnK618nQD0MsBxMh524gehFZ8zY_gN4zhcepnm3xHrc1l2aYaqta3x317hZrRp0X.qnlHq8FuamQO_LL7NSI- X-Yahoo-Newman-Property: ymail-3 From: David Brownell To: "Grant Likely" Subject: Re: [PATCH 2/4] spi: split up spi_new_device() to allow two stage registration. Date: Sun, 29 Jun 2008 21:08:15 -0700 User-Agent: KMail/1.9.9 Cc: linuxppc-dev@ozlabs.org, spi-devel-general@lists.sourceforge.net, linux-kernel@vger.kernel.org, fabrizio.garetto@gmail.com, jonsmirl@gmail.com References: <20080516193054.28030.35126.stgit@trillian.secretlab.ca> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 8bit Content-Disposition: inline Message-Id: <200806292108.15909.david-b@pacbell.net> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday 23 May 2008, Grant Likely wrote: > Question:  spi_alloc_device() (and the original code) does a > spi_master_get() on the spi_master device.  Doesn't spi_master_put() > need to be called when the device is discarded?  spi_dev_put() doesn't > do that explicitly; is it an implicit operation after a device has > been deregistered from the spi_master? Depends whether or not the add() has been done to hook things into the driver model tree, as I recall. The add() presumes things are properly refcounted. When you make a driver model tree node vanish, its associated refcounts get updated too. - Dave