From: Dave Chinner <david@fromorbit.com>
To: Niv Sardi <xaiki@sgi.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] Introduce xfs_trans_bmap_add_attrfork.
Date: Mon, 30 Jun 2008 08:02:21 +1000 [thread overview]
Message-ID: <20080629220221.GK29319@disturbed> (raw)
In-Reply-To: <1214196150-5427-4-git-send-email-xaiki@sgi.com>
On Mon, Jun 23, 2008 at 02:42:29PM +1000, Niv Sardi wrote:
> That takes a transaction and doesn't require everything to be locked
> anymore. this uses the roll trans call.
.....
> error2:
> + if (tpp)
> + tpp = &tp;
That's clearly busted.
if (tpp)
*tpp = tp;
> xfs_bmap_cancel(&flist);
> error1:
> ASSERT(ismrlocked(&ip->i_lock,MR_UPDATE));
> - xfs_iunlock(ip, XFS_ILOCK_EXCL);
> + if (tpp)
> + tpp = &tp;
ditto.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2008-06-29 22:01 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-23 4:42 [RFC] Create with EA initial work Niv Sardi
2008-06-23 4:42 ` [PATCH] Move attr log alloc size calculator to another function Niv Sardi
2008-06-23 4:42 ` [PATCH] Move xfs_attr_rolltrans to xfs_trans_roll Niv Sardi
2008-06-23 4:42 ` [PATCH] Introduce xfs_trans_bmap_add_attrfork Niv Sardi
2008-06-23 4:42 ` [PATCH] Give a transaction to xfs_attr_set_int Niv Sardi
2008-06-29 22:08 ` Dave Chinner
2008-07-01 15:49 ` Josef 'Jeff' Sipek
2008-06-26 9:28 ` [PATCH] Introduce xfs_trans_bmap_add_attrfork Christoph Hellwig
2008-06-27 4:42 ` Niv Sardi
2008-07-02 8:25 ` Timothy Shimmin
2008-07-02 23:39 ` Niv Sardi
2008-06-29 22:02 ` Dave Chinner [this message]
2008-06-26 8:28 ` [PATCH] Move xfs_attr_rolltrans to xfs_trans_roll Christoph Hellwig
2008-06-27 4:44 ` Niv Sardi
2008-06-27 13:03 ` Christoph Hellwig
2008-06-27 13:03 ` Christoph Hellwig
2008-07-02 7:14 ` Timothy Shimmin
2008-06-26 8:24 ` [PATCH] Move attr log alloc size calculator to another function Christoph Hellwig
2008-06-27 4:49 ` Niv Sardi
2008-07-02 6:38 ` Timothy Shimmin
2008-07-10 7:39 ` [UPDATED RFC] Create with EA initial work Niv Sardi
2008-07-10 7:39 ` [PATCH] Move attr log alloc size calculator to another function Niv Sardi
2008-07-10 7:39 ` [PATCH] Move xfs_attr_rolltrans to xfs_trans_roll Niv Sardi
2008-07-10 7:39 ` [PATCH] Introduce xfs_bmap_add_attrfork_trans Niv Sardi
2008-07-10 7:39 ` [PATCH] Give a transaction to xfs_attr_set_int Niv Sardi
2008-07-11 5:38 ` [PATCH] Export xfs_attr_set_int_trans Niv Sardi
2008-07-11 5:38 ` [PATCH] hack to test create + ea Niv Sardi
2008-07-22 4:43 ` [PATCH] Export xfs_attr_set_int_trans Christoph Hellwig
2008-07-22 6:06 ` Niv Sardi
2008-07-23 7:46 ` Christoph Hellwig
2008-07-11 5:44 ` [PATCH] Give a transaction to xfs_attr_set_int Niv Sardi
2008-07-11 5:59 ` Christoph Hellwig
2008-07-23 7:58 ` [PATCH] Introduce xfs_bmap_add_attrfork_trans Christoph Hellwig
2008-07-22 4:38 ` [UPDATED RFC] Create with EA initial work Christoph Hellwig
2008-07-23 5:35 ` Niv Sardi
2008-07-23 7:51 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080629220221.GK29319@disturbed \
--to=david@fromorbit.com \
--cc=xaiki@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.