From: ben@fluff.org.uk
To: linux-kernel@vger.kernel.org, drzeus-mmc@drzeus.cx
Cc: laforge@openmoko.org, tk@maintech.de, Ben Dooks <ben-linux@fluff.org>
Subject: [patch v5 13/16] MMC: S3C24XX: Add media presence test to request handling.
Date: Mon, 30 Jun 2008 22:40:36 +0100 [thread overview]
Message-ID: <20080630214111.384682443@fluff.org.uk> (raw)
In-Reply-To: 20080630214023.140288591@fluff.org.uk
[-- Attachment #1: simtec/s3c24xx-sdmmc-add-mediacheck.patch --]
[-- Type: text/plain, Size: 2127 bytes --]
Ensure that we have physical media present before attempting to
send a request to a card. This ensures that we do not get flooded
by errors from commands that can never be completed timing out.
Signed-off-by: Ben Dooks <ben-linux@fluff.org>
Index: linux-2.6.26-rc8-next20080627/drivers/mmc/host/s3cmci.c
===================================================================
--- linux-2.6.26-rc8-next20080627.orig/drivers/mmc/host/s3cmci.c 2008-06-30 12:36:57.000000000 +0100
+++ linux-2.6.26-rc8-next20080627/drivers/mmc/host/s3cmci.c 2008-06-30 15:23:42.000000000 +0100
@@ -984,6 +984,18 @@ static void s3cmci_send_request(struct m
enable_irq(host->irq);
}
+static int s3cmci_card_present(struct s3cmci_host *host)
+{
+ struct s3c24xx_mci_pdata *pdata = host->pdata;
+ int ret;
+
+ if (pdata->gpio_detect == 0)
+ return -ENOSYS;
+
+ ret = s3c2410_gpio_getpin(pdata->gpio_detect) ? 0 : 1;
+ return ret ^ pdata->detect_invert;
+}
+
static void s3cmci_request(struct mmc_host *mmc, struct mmc_request *mrq)
{
struct s3cmci_host *host = mmc_priv(mmc);
@@ -992,7 +1004,12 @@ static void s3cmci_request(struct mmc_ho
host->cmd_is_stop = 0;
host->mrq = mrq;
- s3cmci_send_request(mmc);
+ if (s3cmci_card_present(host) == 0) {
+ dbg(host, dbg_err, "%s: no medium present\n", __func__);
+ host->mrq->cmd->error = -ENOMEDIUM;
+ mmc_request_done(mmc, mrq);
+ } else
+ s3cmci_send_request(mmc);
}
static void s3cmci_set_ios(struct mmc_host *mmc, struct mmc_ios *ios)
Index: linux-2.6.26-rc8-next20080627/include/asm-arm/plat-s3c24xx/mci.h
===================================================================
--- linux-2.6.26-rc8-next20080627.orig/include/asm-arm/plat-s3c24xx/mci.h 2008-06-30 12:36:42.000000000 +0100
+++ linux-2.6.26-rc8-next20080627/include/asm-arm/plat-s3c24xx/mci.h 2008-06-30 12:37:19.000000000 +0100
@@ -3,6 +3,7 @@
struct s3c24xx_mci_pdata {
unsigned int wprotect_invert : 1;
+ unsigned int detect_invert : 1; /* set => detect active high. */
unsigned int gpio_detect;
unsigned int gpio_wprotect;
--
Ben (ben@fluff.org, http://www.fluff.org/)
'a smiley only costs 4 bytes'
next prev parent reply other threads:[~2008-06-30 21:50 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-30 21:40 [patch v5 00/16] S3C24XX SD/MMC driver ben
2008-06-30 21:40 ` [patch v5 01/16] MMC: S3C24XX MMC/SD driver ben
2008-06-30 21:40 ` [patch v5 02/16] MMC: S3C24XX MMC/SD driver write fixes ben
2008-06-30 21:40 ` [patch v5 03/16] MMC: DMA free fix for S3C24XX SD/MMC driver ben
2008-06-30 21:40 ` [patch v5 04/16] MMC: S3C24XX MMC/SD stop fix ben
2008-06-30 21:40 ` [patch v5 05/16] MMC: Fix S3C24XX IRQ enable during PIO transfers ben
2008-06-30 21:40 ` [patch v5 06/16] MMC: S3C24XX: Add platform data for MMC/SD driver ben
2008-06-30 21:40 ` [patch v5 07/16] MMC: S3C24XX: Add support to invert write protect line ben
2008-06-30 21:40 ` [patch v5 08/16] MMC: S3C24XX: Ensure host->mrq->data is valid ben
2008-06-30 21:40 ` [patch v5 09/16] MMC: S3C24XX: Allow card-detect on non-IRQ capable pin ben
2008-06-30 21:40 ` [patch v5 10/16] MMC: S3C24XX: Fix s3c2410_dma_request() return code check ben
2008-06-30 21:40 ` [patch v5 11/16] MMC: S3C24XX: Add MODULE_ALIAS() entries for the platform devices ben
2008-06-30 21:40 ` [patch v5 12/16] MMC: S3C24XX: Fix use of msecs where jiffies are needed ben
2008-06-30 21:40 ` ben [this message]
2008-06-30 21:40 ` [patch v5 14/16] MMC: S3C24XX: Update error debugging ben
2008-06-30 21:40 ` [patch v5 15/16] MMC: S3C24XX: Add maintainer entry ben
2008-06-30 21:40 ` [patch v5 16/16] MMC: S3C24XX: Refuse incorrectly aligned transfers ben
2008-06-30 21:47 ` [patch v5 00/16] S3C24XX SD/MMC driver Ben Dooks
2008-07-04 17:05 ` Pierre Ossman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080630214111.384682443@fluff.org.uk \
--to=ben@fluff.org.uk \
--cc=ben-linux@fluff.org \
--cc=drzeus-mmc@drzeus.cx \
--cc=laforge@openmoko.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tk@maintech.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.