From: Christoph Hellwig <hch@infradead.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Denys Vlasenko <vda.linux@googlemail.com>,
Al Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] (resend) reuse xxx_fifo_fops for xxx_pipe_fops
Date: Tue, 1 Jul 2008 04:15:40 -0400 [thread overview]
Message-ID: <20080701081540.GA20332@infradead.org> (raw)
In-Reply-To: <20080701011045.f4490332.akpm@linux-foundation.org>
On Tue, Jul 01, 2008 at 01:10:45AM -0700, Andrew Morton wrote:
> On Tue, 1 Jul 2008 12:03:50 +0200 Denys Vlasenko <vda.linux@googlemail.com> wrote:
>
> > I think since XXX_pipe_fops are only used in this file,
> > just explaining this in the comment would be enough.
>
> no, a comment is only needed when the code is unobvious. Make
> the code obvious and we don't need a comment.
>
> As Christoph pointed out, open-coding shared_read_fops everywhere
> might make sense too. It'd make it harder to unshare them later
> on, but that's pretty improbable.
Deny's latest patch doesn't have the #defines anymore and looks quite
reasonable to me. If you really insist on magic naming I think shared
is a very bad choice because it doesn't have any useful meaning in this
context. If you insist on magic naming do _pipefifo_, but I think
the current version with the comment is much better.
next prev parent reply other threads:[~2008-07-01 8:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-01 9:03 [PATCH] (resend) reuse xxx_fifo_fops for xxx_pipe_fops Denys Vlasenko
2008-07-01 7:31 ` Christoph Hellwig
2008-07-01 7:32 ` Andrew Morton
2008-07-01 10:03 ` Denys Vlasenko
2008-07-01 8:10 ` Andrew Morton
2008-07-01 8:15 ` Christoph Hellwig [this message]
2008-07-01 12:11 ` Denys Vlasenko
2008-07-01 12:16 ` Denys Vlasenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080701081540.GA20332@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vda.linux@googlemail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.