All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ivo van Doorn <ivdoorn@gmail.com>
To: "Adel Gadllah" <adel.gadllah@gmail.com>
Cc: "Johannes Berg" <johannes@sipsolutions.net>,
	linux-wireless@vger.kernel.org, "Michael Buesch" <mb@bu3sch.de>,
	stefano.brivio@polimi.it,
	"Larry Finger" <larry.finger@lwfinger.net>,
	"John W. Linville" <linville@tuxdriver.com>,
	"Henrique de Moraes Holschuh" <hmh@hmh.eng.br>
Subject: Re: [PATCH/RFC v3] b43: remove input device usage for rfkill
Date: Tue, 1 Jul 2008 12:29:32 +0200	[thread overview]
Message-ID: <200807011229.37389.IvDoorn@gmail.com> (raw)
In-Reply-To: <6cf6b73e0807010319x88f3624x83465cc314d8962f@mail.gmail.com>

> -	/* send the radio switch event to the system - note both a key press
> -	 * and a release are required */
> -	if (unlikely(report_change)) {
> -		input_report_key(poll_dev->input, KEY_WLAN, 1);
> -		input_report_key(poll_dev->input, KEY_WLAN, 0);
> -	}

So how will b43 report the status change now? Shouldn't the above be replaced
with a call to rfkill_force_state()?

Ivo

  parent reply	other threads:[~2008-07-01 10:25 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-01  9:55 [PATCH/RFC] b43: remove input device usage for rfkill Adel Gadllah
2008-07-01  9:58 ` Johannes Berg
2008-07-01 10:05   ` [PATCH/RFC v2] " Adel Gadllah
2008-07-01 10:08     ` Johannes Berg
2008-07-01 10:19       ` [PATCH/RFC v3] " Adel Gadllah
2008-07-01 10:23         ` Johannes Berg
2008-07-01 10:31           ` drago01
2008-07-01 10:29         ` Michael Buesch
2008-07-01 10:34           ` drago01
2008-07-01 10:29         ` Ivo van Doorn [this message]
2008-07-01 10:27 ` [PATCH/RFC] " Michael Buesch
2008-07-01 10:33   ` drago01
2008-07-01 10:38     ` Michael Buesch
2008-07-01 14:34   ` Henrique de Moraes Holschuh
2008-07-01 14:38     ` Johannes Berg
2008-07-01 16:50       ` Henrique de Moraes Holschuh
2008-07-01 17:01         ` Johannes Berg
2008-07-01 17:14           ` Larry Finger
2008-07-01 17:35             ` Henrique de Moraes Holschuh
2008-07-01 18:21               ` Larry Finger
2008-07-01 21:20                 ` Dan Williams
2008-07-02  2:45                   ` Larry Finger
2008-07-01 17:33           ` Henrique de Moraes Holschuh
2008-07-01 18:01             ` Johannes Berg
2008-07-01 18:41               ` Henrique de Moraes Holschuh
2008-07-01 18:44                 ` Johannes Berg
2008-07-01 22:52                   ` Henrique de Moraes Holschuh
2008-07-01 22:56                     ` Johannes Berg
2008-07-01 23:57                       ` Henrique de Moraes Holschuh
2008-07-02  2:43                         ` Larry Finger
2008-07-02  7:21                         ` Johannes Berg
2008-07-02  7:31                           ` Johannes Berg
2008-07-02 16:02                             ` Henrique de Moraes Holschuh
2008-07-02 13:16                           ` Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200807011229.37389.IvDoorn@gmail.com \
    --to=ivdoorn@gmail.com \
    --cc=adel.gadllah@gmail.com \
    --cc=hmh@hmh.eng.br \
    --cc=johannes@sipsolutions.net \
    --cc=larry.finger@lwfinger.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=mb@bu3sch.de \
    --cc=stefano.brivio@polimi.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.