All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Greg KH <greg@kroah.com>
Cc: Roland McGrath <roland@redhat.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	TAKADA Yoshihito <takada@mbf.nifty.com>,
	linux-kernel@vger.kernel.org, stable@kernel.org
Subject: Re: [stable] [PATCH] x86 ptrace: fix PTRACE_GETFPXREGS error
Date: Tue, 1 Jul 2008 16:46:58 +0200	[thread overview]
Message-ID: <20080701144658.GA18522@elte.hu> (raw)
In-Reply-To: <20080701143418.GA30693@kroah.com>


* Greg KH <greg@kroah.com> wrote:

> On Tue, Jul 01, 2008 at 12:11:04PM +0200, Ingo Molnar wrote:
> > 
> > * Roland McGrath <roland@redhat.com> wrote:
> > 
> > > > since the original fix is already upstream, i've applied the delta 
> > > > patch below. Should we still do this for v2.6.26 or can we defer it 
> > > > to v2.6.27? As ptrace is the only user of this facility for now this 
> > > > would be an identity transformation AFAICS and the v2.6.26 release 
> > > > is very close.
> > > 
> > > I don't think there's a problem with 2.6.26 either way.  I agree that 
> > > the user_regset internal API does not matter much before 2.6.27.
> > 
> > okay - i've queued it up in tip/x86/ptrace for now.
> > 
> > > My patch alone applies to 2.6.25, which is why I CC'd it to stable. I 
> > > think applying that (and not takada's patch) to stable-2.6.25 would be 
> > > best.
> > 
> > i think Greg already queued the original fix up for v2.6.25, as per the 
> > commit notifier below.
> 
> Yes I did queue that one up, but it looks different from Roland's 
> original patch in this thread.

yes, but as discussed in this thread, both patches are fine in principle 
as far as the regression goes.

	Ingo

  reply	other threads:[~2008-07-01 14:47 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-30  4:44 [PATCH] ptrace GET/SET FPXREGS broken TAKADA Yoshihito
2008-06-30 12:18 ` Ingo Molnar
2008-06-30 21:02 ` [PATCH] x86 ptrace: fix PTRACE_GETFPXREGS error Roland McGrath
2008-07-01  9:02   ` Ingo Molnar
2008-07-01  9:32     ` Roland McGrath
2008-07-01 10:11       ` Ingo Molnar
2008-07-01 14:34         ` [stable] " Greg KH
2008-07-01 14:46           ` Ingo Molnar [this message]
2008-07-01 15:02             ` Greg KH
2008-07-03  2:37     ` TAKADA Yoshihito
2008-07-03  1:58   ` TAKADA Yoshihito
2008-07-03  3:00     ` Roland McGrath
2008-06-30 21:02 ` [PATCH] ptrace GET/SET FPXREGS broken Roland McGrath

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080701144658.GA18522@elte.hu \
    --to=mingo@elte.hu \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=roland@redhat.com \
    --cc=stable@kernel.org \
    --cc=takada@mbf.nifty.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.