From: Jesper Nilsson <jesper.nilsson@axis.com>
To: Hinko Kocevar <hinko.kocevar@cetrtapot.si>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
dev-etrax <dev-etrax@axis.com>, Sam Ravnborg <sam@ravnborg.org>
Subject: Re: [PATCH linux-next 1/1] cris: look for linker scripts in srctree not in objtree
Date: Tue, 1 Jul 2008 18:02:41 +0200 [thread overview]
Message-ID: <20080701160240.GD3921@axis.com> (raw)
In-Reply-To: <486A3A6C.4000506@cetrtapot.si>
Hi!
On Tue, Jul 01, 2008 at 04:08:44PM +0200, Hinko Kocevar wrote:
> When building kernel with O= linker looks for linker scripts in output tree, while they are located in source tree.
>
> Signed-off-by: Hinko Kocevar <hinko.kocevar@cetrtapot.si>
I think this would be cleaner:
diff --git a/arch/cris/arch-v10/boot/compressed/Makefile b/arch/cris/arch-v10/boot/compressed/Makefile
--- a/arch/cris/arch-v10/boot/compressed/Makefile
+++ b/arch/cris/arch-v10/boot/compressed/Makefile
@@ -4,7 +4,7 @@
asflags-y += $(LINUXINCLUDE)
ccflags-y += -O2 $(LINUXINCLUDE)
-ldflags-y += -T $(obj)/decompress.ld
+ldflags-y += -T $(srctree)/$(src)/decompress.ld
OBJECTS = $(obj)/head.o $(obj)/misc.o
OBJCOPYFLAGS = -O binary --remove-section=.bss
diff --git a/arch/cris/arch-v10/boot/rescue/Makefile b/arch/cris/arch-v10/boot/rescue/Makefile
--- a/arch/cris/arch-v10/boot/rescue/Makefile
+++ b/arch/cris/arch-v10/boot/rescue/Makefile
@@ -4,7 +4,7 @@
ccflags-y += -O2 $(LINUXINCLUDE)
asflags-y += $(LINUXINCLUDE)
-ldflags-y += -T $(obj)/rescue.ld
+ldflags-y += -T $(srctree)/$(src)/rescue.ld
OBJCOPYFLAGS = -O binary --remove-section=.bss
obj-$(CONFIG_ETRAX_AXISFLASHMAP) = head.o
OBJECT := $(obj)/head.o
> ---
> diff --git a/arch/cris/arch-v10/boot/compressed/Makefile b/arch/cris/arch-v10/boot/compressed/Makefile
> index 9ec5f87..cc6527d 100644
> --- a/arch/cris/arch-v10/boot/compressed/Makefile
> +++ b/arch/cris/arch-v10/boot/compressed/Makefile
> @@ -4,7 +4,7 @@
>
> asflags-y += $(LINUXINCLUDE)
> ccflags-y += -O2 $(LINUXINCLUDE)
> -ldflags-y += -T $(obj)/decompress.ld
> +ldflags-y += -T $(srctree)/arch/$(ARCH)/boot/compressed/decompress.ld
> OBJECTS = $(obj)/head.o $(obj)/misc.o
> OBJCOPYFLAGS = -O binary --remove-section=.bss
>
> diff --git a/arch/cris/arch-v10/boot/rescue/Makefile b/arch/cris/arch-v10/boot/rescue/Makefile
> index bea8b9c..476007d 100644
> --- a/arch/cris/arch-v10/boot/rescue/Makefile
> +++ b/arch/cris/arch-v10/boot/rescue/Makefile
> @@ -4,7 +4,7 @@
>
> ccflags-y += -O2 $(LINUXINCLUDE)
> asflags-y += $(LINUXINCLUDE)
> -ldflags-y += -T $(obj)/rescue.ld
> +ldflags-y += -T $(srctree)/arch/$(ARCH)/boot/rescue/rescue.ld
> OBJCOPYFLAGS = -O binary --remove-section=.bss
> obj-$(CONFIG_ETRAX_AXISFLASHMAP) = head.o
> OBJECT := $(obj)/head.o
Thanks!
/^JN - Jesper Nilsson
--
Jesper Nilsson -- jesper.nilsson@axis.com
next prev parent reply other threads:[~2008-07-01 16:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-06 11:36 [PATCH 2.6.26-rc5 0/2] cris: compile fixes for 2.6.26-rc5 Hinko Kočevar
2008-06-06 11:37 ` [PATCH 2.6.26-rc5 1/2] " Hinko Kočevar
2008-06-06 11:41 ` Alan Cox
2008-06-06 12:12 ` Hinko Koc(evar
2008-06-06 15:05 ` Alan Cox
2008-06-06 11:38 ` [PATCH 2.6.26-rc5 2/2] " Hinko Kočevar
2008-06-06 18:32 ` [PATCH 2.6.26-rc5 0/2] " Adrian Bunk
2008-06-10 9:49 ` Jesper Nilsson
2008-06-10 10:15 ` Stephen Rothwell
2008-07-01 14:08 ` [PATCH linux-next 1/1] cris: look for linker scripts in srctree not in objtree Hinko Kocevar
2008-07-01 16:02 ` Jesper Nilsson [this message]
2008-07-01 19:29 ` Sam Ravnborg
2008-07-02 7:13 ` Hinko Kocevar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080701160240.GD3921@axis.com \
--to=jesper.nilsson@axis.com \
--cc=dev-etrax@axis.com \
--cc=hinko.kocevar@cetrtapot.si \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.