From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KDiPh-0004iJ-4L for mharc-grub-devel@gnu.org; Tue, 01 Jul 2008 12:09:05 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KDiPf-0004hP-Qp for grub-devel@gnu.org; Tue, 01 Jul 2008 12:09:03 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KDiPf-0004h0-6Q for grub-devel@gnu.org; Tue, 01 Jul 2008 12:09:03 -0400 Received: from [199.232.76.173] (port=36103 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KDiPf-0004gw-3G for grub-devel@gnu.org; Tue, 01 Jul 2008 12:09:03 -0400 Received: from aybabtu.com ([69.60.117.155]:55304) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KDiPe-0007t5-Te for grub-devel@gnu.org; Tue, 01 Jul 2008 12:09:03 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.69) (envelope-from ) id 1KDiLw-0003l2-1F for grub-devel@gnu.org; Tue, 01 Jul 2008 18:05:12 +0200 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1KDiP5-0001xw-FB for grub-devel@gnu.org; Tue, 01 Jul 2008 18:08:27 +0200 Date: Tue, 1 Jul 2008 18:08:27 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20080701160827.GF6985@thorin> References: <889404A5CBB14C15B464EDBB1AE338A8@fz> <1214765178.6942.2.camel@localhost> <1214769230.6942.11.camel@localhost> <20080629211957.GD24784@thorin> <1214794971.9353.32.camel@localhost> <4868C017.8040004@isaac.cedarswampstudios.org> <1214827937.9353.43.camel@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: grub-probe detects ext4 wronly as ext2 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Jul 2008 16:09:04 -0000 On Mon, Jun 30, 2008 at 08:27:50PM +0800, Bean wrote: > On Mon, Jun 30, 2008 at 8:12 PM, Javier Martín wrote: > > El lun, 30-06-2008 a las 07:14 -0400, Isaac Dupree escribió: > >> > +#define EXT3_FEATURE_INCOMPAT_RECOVER 0x0004 /* Needs recovery */ > >> > >> > +#define EXT2_DRIVER_SUPPORTED_INCOMPAT ( EXT2_FEATURE_INCOMPAT_FILETYPE ) > >> > >> I suspect this will mean that journalled ext3 when the system crashed > >> (so the filesystem "needs recovery" from the journal) won't load. (Of > >> course, properly speaking that would load grub's code to replay the > >> journal...) But I think that (without other changes) that would make > >> the system unbootable every time there was a power outage? (Of course > >> it was not guaranteed to load correctly when ignoring the journal when > >> it needed recovery, but it was likely to work, IIUC.) > >> > >> -Isaac > > > > As I said, I didn't add it because I didn't know whether recovery was > > supported or not. _Theoretically_ we should focus on correctness and > > refuse to read such a filesystem, but here goes a workaround for > > incompatible features that we do not support but still willingly want to > > ignore for the sake of "compatibility". This new version of the patch > > adds another macro, EXT2_DRIVER_IGNORED_INCOMPAT where we can put > > features that we don't fully support, but still want a filesystem with > > them to be mounted, like the needs_recover flag. > > > > Of course, this is risky: INCOMPAT_* features are so for a reason, but > > it will allow dirty ext3 filesystems to be mounted until we have a > > working journal implementation. I had thought of adding some kind of > > warning, but since GRUB mounts and umounts filesystems constantly, it > > just cluttered the screen and I removed it. > > Hi, > > We must not quit if the journal flag is set, even if we don't handle > it. grub-setup runs in a active system, the journal wouldn't be empty. > If we just quit, we can't even install. I think we should be more conservative here, and only reject a filesystem when we know _for sure_ that GRUB won't be able to access it. Otherwise we may be disabling filesystems that are probably fine. -- Robert Millan I know my rights; I want my phone call! What good is a phone call… if you are unable to speak? (as seen on /.)