From: Stephen Hemminger <stephen.hemminger@vyatta.com>
To: "Adam Langley" <agl@imperialviolet.org>
Cc: "Stephen Hemminger" <shemminger@vyatta.com>, netdev@vger.kernel.org
Subject: Re: MD5 SG fix
Date: Tue, 1 Jul 2008 16:10:53 -0700 [thread overview]
Message-ID: <20080701161053.43c0b627@speedy> (raw)
In-Reply-To: <396556a20807011552p63d59fd9ja70bfe581798a164@mail.gmail.com>
On Tue, 1 Jul 2008 15:52:56 -0700
"Adam Langley" <agl@imperialviolet.org> wrote:
> On Tue, Jul 1, 2008 at 3:49 PM, Stephen Hemminger <shemminger@vyatta.com> wrote:
> > Just pass the skb in and not tcplen, frags, ...
> > avoid all this nonsense. tcplen == skb->len, and you have the correct size info.
>
> But there are places where that function is called that we don't have
> an SKB to pass in (tcp_v6_send_reset and tcp_v6_send_ack, likewise in
> v4). I could duplicate the whole function, once for SKBs and once for
> those users, but that's a bunch of duplicated code. I'll defer to your
> experience on what the kernel's preferred practice is here.
>
Break the calc function into:
setup header
setup data
calculate
Then make two handles, one for data block, other for skb
If you want, let's take this off list and I'll bounce you back what I mean.
next prev parent reply other threads:[~2008-07-01 23:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-01 21:16 MD5 SG fix Adam Langley
2008-07-01 21:39 ` Stephen Hemminger
2008-07-01 21:48 ` Adam Langley
2008-07-01 21:49 ` Adam Langley
2008-07-01 22:38 ` Adam Langley
2008-07-01 22:46 ` Stephen Hemminger
2008-07-01 22:49 ` Stephen Hemminger
2008-07-01 22:52 ` Adam Langley
2008-07-01 23:10 ` Stephen Hemminger [this message]
2008-07-02 4:55 ` Evgeniy Polyakov
2008-07-04 0:07 ` Adam Langley
2008-07-04 4:02 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080701161053.43c0b627@speedy \
--to=stephen.hemminger@vyatta.com \
--cc=agl@imperialviolet.org \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.