From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Brownell Subject: Re: [PATCH 001/002] linux-input: bcm5974-0.31: fixed resource leak, removed work struct, device data struct introduced Date: Tue, 1 Jul 2008 20:04:16 -0700 Message-ID: <200807012004.17292.david-b@pacbell.net> References: <1214653629.10495.11.camel@alnilam> <20080701155925.a4c00a8e.akpm@linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <20080701155925.a4c00a8e.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org> Content-Disposition: inline Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Andrew Morton Cc: Henrik Rydberg , linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, robfitz-lqAI2a470fI@public.gmane.org, jikos-wDf7oJUeT2I@public.gmane.org, vojtech-AlSwsSmVLrQ@public.gmane.org, dmonakhov-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org, linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-input@vger.kernel.org On Tuesday 01 July 2008, Andrew Morton wrote: > I dunno what USB driver normally use for their dma memory. =A0Perhaps > dma_alloc_coherent()? kmalloc() as a rule ... dma_alloc_coherent() only makes sense if the buffer gets reused enough that the dma mapping ops (or as I think of them, cache maintainence ops) really hurt. - Dave -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762191AbYGBDRi (ORCPT ); Tue, 1 Jul 2008 23:17:38 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754194AbYGBDQ5 (ORCPT ); Tue, 1 Jul 2008 23:16:57 -0400 Received: from smtp115.sbc.mail.sp1.yahoo.com ([69.147.64.88]:43161 "HELO smtp115.sbc.mail.sp1.yahoo.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1753146AbYGBDQ4 (ORCPT ); Tue, 1 Jul 2008 23:16:56 -0400 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=s1024; d=pacbell.net; h=Received:X-YMail-OSG:X-Yahoo-Newman-Property:From:To:Subject:Date:User-Agent:Cc:References:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding:Content-Disposition:Message-Id; b=mXVwgiYL91BlJ/5B/eW77kfMO8yl/7ClELi0kFKZMiCx/jZK9WjODd1Ai4Loh+qY5ie4vSrUVlxznzCMNVfxbK1MBxYzQnXOtXbcPDOm/53Z7fM1GxKM7QM5SCJfb6JJ0BDh4w2+d6ZY/St/yLCbfZC9FH3Va/ZKBpWADXFykwQ= ; X-YMail-OSG: zoRBWacVM1m.zxEkHjbnPvL0JFpFkDAXXpx6g1sXMhrL6U5.1sFOFo10wsyv7TWjesIJTA2u5AHffQ2zidEx9O83nzvWSoPMhLTgH1Tqis7G_98tE29SSDZl.UFs2pXra8M- X-Yahoo-Newman-Property: ymail-3 From: David Brownell To: Andrew Morton Subject: Re: [PATCH 001/002] linux-input: bcm5974-0.31: fixed resource leak, removed work struct, device data struct introduced Date: Tue, 1 Jul 2008 20:04:16 -0700 User-Agent: KMail/1.9.9 Cc: Henrik Rydberg , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, dmitry.torokhov@gmail.com, robfitz@273k.net, jikos@jikos.cz, vojtech@suse.cz, dmonakhov@openvz.org, linux-usb@vger.kernel.org References: <1214653629.10495.11.camel@alnilam> <20080701155925.a4c00a8e.akpm@linux-foundation.org> In-Reply-To: <20080701155925.a4c00a8e.akpm@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 8bit Content-Disposition: inline Message-Id: <200807012004.17292.david-b@pacbell.net> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 01 July 2008, Andrew Morton wrote: > I dunno what USB driver normally use for their dma memory.  Perhaps > dma_alloc_coherent()? kmalloc() as a rule ... dma_alloc_coherent() only makes sense if the buffer gets reused enough that the dma mapping ops (or as I think of them, cache maintainence ops) really hurt. - Dave