From: Olof Johansson <olof@lixom.net>
To: Roland Dreier <rdreier@cisco.com>
Cc: jeff@garzik.org, netdev@vger.kernel.org
Subject: Re: [PATCH] pasemi_mac: Access iph->tot_len with correct endianness
Date: Tue, 1 Jul 2008 23:24:26 -0500 [thread overview]
Message-ID: <20080702042426.GA27717@lixom.net> (raw)
In-Reply-To: <ada63rpecyi.fsf@cisco.com>
On Tue, Jul 01, 2008 at 10:22:45AM -0700, Roland Dreier wrote:
> iph->tot_len is stored in network byte order, so access it using
> ntohs(). This doesn't have any real world impact on pasemi_mac, since
> the device only exists as part of a big-endian system-on-chip, but
> fixing this gets rid of a sparse warning and avoids having a bad example
> in the tree.
>
> Signed-off-by: Roland Dreier <rolandd@cisco.com>
Acked-by: Olof Johansson <olof@lixom.net>
prev parent reply other threads:[~2008-07-02 4:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-01 17:22 [PATCH] pasemi_mac: Access iph->tot_len with correct endianness Roland Dreier
2008-07-02 4:24 ` Olof Johansson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080702042426.GA27717@lixom.net \
--to=olof@lixom.net \
--cc=jeff@garzik.org \
--cc=netdev@vger.kernel.org \
--cc=rdreier@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.