Re: [ANNOUNCE] ipset-2.3.2

[Ludwig Nussel <ludwig.nussel@suse.de>]

Ludwig Nussel wrote:
> Jozsef Kadlecsik wrote:
> > I'm happy to announce ipset-2.3.2. Besides cosmetic changes and cleanups, 
> > this release includes the sources of both the userspace tool and the 
> > kernel modules: you can install ipset wihtout patch-o-matic-ng. Please 
> > read the README file for the instructions on how to install ipset without 
> > pom-ng.
> 
> Ah, nice. I'd like to suggest to add the following patch. It
> separates building the kernel modules and the user space parts. That
> [...]
> +ipset: $(PROGRAMS) $(SHARED_LIBS)

*grmbl* Not using targets that are also programs actually
produces a working binary.

Signed-off-by: Ludwig Nussel <ludwig.nussel@suse.de>

diff --git a/Makefile b/Makefile
index 3b4abe1..e049d4f 100644
--- a/Makefile
+++ b/Makefile
@@ -36,9 +36,9 @@ SHARED_LIBS=$(foreach T, $(SETTYPES),libipset_$(T).so)
 INSTALL=$(DESTDIR)$(BINDIR)/ipset $(DESTDIR)$(MANDIR)/man8/ipset.8
 INSTALL+=$(foreach T, $(SETTYPES), $(DESTDIR)$(LIBDIR)/ipset/libipset_$(T).so)
 
-all: ipset modules
+all: userspace modules
 
-ipset: $(PROGRAMS) $(SHARED_LIBS)
+userspace: $(PROGRAMS) $(SHARED_LIBS)
 
 modules:
 	cd kernel; make -C $(KERNEL_DIR) M=`pwd` IP_NF_SET_MAX=$(IP_NF_SET_MAX) IP_NF_SET_HASHSIZE=$(IP_NF_SET_HASHSIZE) modules
@@ -48,7 +48,7 @@ modules:
 tests:
 	cd tests; ./runtest.sh
 
-ipset_install: ipset $(INSTALL)
+ipset_install: userspace $(INSTALL)
 
 modules_install: modules
 	cd kernel; make -C $(KERNEL_DIR) M=`pwd` modules_install
-- 
1.5.6

-- 
 (o_   Ludwig Nussel
 //\   
 V_/_  http://www.suse.de/
SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nuernberg)