From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KEPT1-0008I2-7l for mharc-grub-devel@gnu.org; Thu, 03 Jul 2008 10:07:23 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KEPSz-0008Hw-Ro for grub-devel@gnu.org; Thu, 03 Jul 2008 10:07:21 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KEPSz-0008Hk-0Z for grub-devel@gnu.org; Thu, 03 Jul 2008 10:07:21 -0400 Received: from [199.232.76.173] (port=36931 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KEPSy-0008Hh-S5 for grub-devel@gnu.org; Thu, 03 Jul 2008 10:07:20 -0400 Received: from aybabtu.com ([69.60.117.155]:48006) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KEPSy-0005PX-Dm for grub-devel@gnu.org; Thu, 03 Jul 2008 10:07:20 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.69) (envelope-from ) id 1KEPOy-0005CL-Af for grub-devel@gnu.org; Thu, 03 Jul 2008 16:03:13 +0200 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1KEPSC-0005Hp-Kl for grub-devel@gnu.org; Thu, 03 Jul 2008 16:06:32 +0200 Date: Thu, 3 Jul 2008 16:06:32 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20080703140632.GA20158@thorin> References: <20080702144227.GD21064@thorin> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] LZMA support in i386-pc kernel X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Jul 2008 14:07:22 -0000 On Wed, Jul 02, 2008 at 11:11:28PM +0800, Bean wrote: > > > > Lenny's most likely going to ship with lzma 4.43. Is that good? > > The c encoder first appears in 4.58 beta. Previous version of lzma > only have cpp version. That's too bad, I guess it'll have to be for lenny+1. > >> +#define FIXED_PROPS > >> [...] > >> +#ifdef FIXED_PROPS > > > > What's this option for? Some comment would be nice. > > lzma have three properties that control its behavior, lc, lp and pb. > We can use these values as variable or constant. The default value, 3, > 0, 2 is nice in most case, we hardly need to change them. So I use it > as constant to save some extra space. Could you make a comment out of this? :-) > >> +#if 0 > >> + > >> +DbgOut: > > > > This is just for debugging, right? Maybe "#ifdef DEBUG" or so would be > > better, to make it clear. > > Yes, this is used in debugging. Now it's working, it's not needed > anymore. I think it's better to keep it disable like this. The kernel > raw space is critical, if we happen to define DEBUG, the decoder code > would expand and kernel.img would fail to compile any more. Ok. > >> +#ifndef ASM_FILE > >> + xorl %eax, %eax > >> +#endif > > > > Why? I thought ASM_FILE always ought to be defined for asm files in GRUB. > > This is also used in debugging. Previously, I link it with c program > to check the decoder, which require to keep register like %esi, %edi, > %ebx. But inside grub, there is no need to keep them. I use ASM_FILE > to distinguish between these two conditions. Ok. If you intend to keep it, please add a note explaining why; it looks a bit puzzling without it. -- Robert Millan I know my rights; I want my phone call! What good is a phone call… if you are unable to speak? (as seen on /.)