From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KEPWH-00018l-M3 for mharc-grub-devel@gnu.org; Thu, 03 Jul 2008 10:10:45 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KEPWG-00017Q-4f for grub-devel@gnu.org; Thu, 03 Jul 2008 10:10:44 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KEPWF-00016v-JA for grub-devel@gnu.org; Thu, 03 Jul 2008 10:10:43 -0400 Received: from [199.232.76.173] (port=38823 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KEPWF-00016l-31 for grub-devel@gnu.org; Thu, 03 Jul 2008 10:10:43 -0400 Received: from aybabtu.com ([69.60.117.155]:48008) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KEPWB-00061v-7A; Thu, 03 Jul 2008 10:10:39 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.69) (envelope-from ) id 1KEPSG-0005Cc-Dr; Thu, 03 Jul 2008 16:06:36 +0200 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1KEPVZ-0005Jk-9y; Thu, 03 Jul 2008 16:10:01 +0200 Date: Thu, 3 Jul 2008 16:10:01 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20080703141001.GB20158@thorin> References: <20080703001716.13881.1754.stgit@dv.roinet.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20080703001716.13881.1754.stgit@dv.roinet.com> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Cc: Marco Gerards Subject: Re: [PATCH] Enable writing to ATA devices, fix several bugs X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Jul 2008 14:10:44 -0000 On Wed, Jul 02, 2008 at 08:17:16PM -0400, Pavel Roskin wrote: > + if (grub_ata_regget (dev, GRUB_ATA_REG_STATUS) & 1) > + return grub_ata_regget (dev, GRUB_ATA_REG_ERROR); May I suggest a macro to describe this "1"? -- Robert Millan I know my rights; I want my phone call! What good is a phone call… if you are unable to speak? (as seen on /.)