From: Andrew Morton <akpm@linux-foundation.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org, tglx@linutronix.de,
torvalds@linux-foundation.org, akpm@linuxfoundation.org,
peterz@infradead.org, stable@kernel.org
Subject: Re: [PATCH] hrtimer: prevent migration for raising softirq
Date: Thu, 3 Jul 2008 15:53:02 -0700 [thread overview]
Message-ID: <20080703155302.5f86d8f4.akpm@linux-foundation.org> (raw)
In-Reply-To: <Pine.LNX.4.58.0807031428440.7798@gandalf.stny.rr.com>
On Thu, 3 Jul 2008 14:31:26 -0400 (EDT)
Steven Rostedt <rostedt@goodmis.org> wrote:
> Due to a possible deadlock, the waking of the softirq was pushed outside
> of the hrtimer base locks. See commit 0c96c5979a522c3323c30a078a70120e29b5bdbc
Please quote at least the patch title rather than raw hashes.
afaict that patch isn't in 2.6.25 yet you copied stable@kernel.org.
Please clarify.
>
> Unfortunately this allows the task to migrate after setting up the softirq
> and raising it. Since softirqs run a queue that is per-cpu we may raise the
> softirq on the wrong CPU and this will keep the queued softirq task from
> running.
>
> To solve this issue, this patch disables preemption around the releasing
> of the hrtimer lock and raising of the softirq.
>
This seems to be 2.6.26 material and is inapplicable to 2.6.25?
next prev parent reply other threads:[~2008-07-03 22:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-03 18:31 [PATCH] hrtimer: prevent migration for raising softirq Steven Rostedt
2008-07-03 22:53 ` Andrew Morton [this message]
2008-07-04 1:56 ` Steven Rostedt
2008-07-04 2:03 ` Andrew Morton
2008-07-04 2:20 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080703155302.5f86d8f4.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=akpm@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=stable@kernel.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.