From: Ivo van Doorn <ivdoorn@gmail.com>
To: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Cc: John Linville <linville@tuxdriver.com>, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/2] rfkill: some minor kernel-doc changes for rfkill_toggle_radio
Date: Thu, 3 Jul 2008 18:24:51 +0200 [thread overview]
Message-ID: <200807031824.51204.IvDoorn@gmail.com> (raw)
In-Reply-To: <1215101697-30576-2-git-send-email-hmh@hmh.eng.br>
On Thursday 03 July 2008, Henrique de Moraes Holschuh wrote:
> Improve rfkill_toggle_radio's kernel-doc header a bit.
>
> Signed-off-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
> Cc: Ivo van Doorn <IvDoorn@gmail.com>
Acked-by: Ivo van Doorn <IvDoorn@gmail.com>
> ---
> net/rfkill/rfkill.c | 12 +++++++-----
> 1 files changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/net/rfkill/rfkill.c b/net/rfkill/rfkill.c
> index ce0e231..aa7039d 100644
> --- a/net/rfkill/rfkill.c
> +++ b/net/rfkill/rfkill.c
> @@ -130,17 +130,19 @@ static void update_rfkill_state(struct rfkill *rfkill)
>
> /**
> * rfkill_toggle_radio - wrapper for toggle_radio hook
> - * calls toggle_radio taking into account a lot of "small"
> - * details.
> + *
> * @rfkill: the rfkill struct to use
> * @force: calls toggle_radio even if cache says it is not needed,
> * and also makes sure notifications of the state will be
> * sent even if it didn't change
> * @state: the new state to call toggle_radio() with
> *
> - * This wrappen protects and enforces the API for toggle_radio
> - * calls. Note that @force cannot override a (possibly cached)
> - * state of RFKILL_STATE_HARD_BLOCKED. Any device making use of
> + * Calls rfkill->toggle_radio, enforcing the API for toggle_radio
> + * calls and handling all the red tape such as issuing notifications
> + * if the call is successful.
> + *
> + * Note that @force cannot override a (possibly cached) state of
> + * RFKILL_STATE_HARD_BLOCKED. Any device making use of
> * RFKILL_STATE_HARD_BLOCKED implements either get_state() or
> * rfkill_force_state(), so the cache either is bypassed or valid.
> *
next prev parent reply other threads:[~2008-07-03 16:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-03 16:14 [GIT PATCH] rfkill fixes Henrique de Moraes Holschuh
2008-07-03 16:14 ` [PATCH 1/2] rfkill: some minor kernel-doc changes for rfkill_toggle_radio Henrique de Moraes Holschuh
2008-07-03 16:24 ` Ivo van Doorn [this message]
2008-07-03 16:14 ` [PATCH 2/2] rfkill: ignore errors from rfkill_toggle_radio in rfkill_add_switch Henrique de Moraes Holschuh
2008-07-03 16:25 ` Ivo van Doorn
2008-07-03 16:37 ` Tomas Winkler
2008-07-03 16:47 ` Ivo van Doorn
2008-07-03 16:45 ` Tomas Winkler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200807031824.51204.IvDoorn@gmail.com \
--to=ivdoorn@gmail.com \
--cc=hmh@hmh.eng.br \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.