From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Harald Welte <laforge@gnumonks.org>
Cc: linux-acpi@vger.kernel.org, Hiroshi Miura <miura@da-cha.org>
Subject: Re: [PATCH] Panasonic Let's Note laptop extras driver v0.93
Date: Thu, 3 Jul 2008 20:23:03 +0100 [thread overview]
Message-ID: <20080703192303.GA32260@srcf.ucam.org> (raw)
In-Reply-To: <20080703173542.GA5118@prithivi.gnumonks.org>
On Fri, Jul 04, 2008 at 01:35:42AM +0800, Harald Welte wrote:
> +
> +static int pcc_setkeycode(struct input_dev *dev, int scancode, int keycode)
> +{
> + struct pcc_acpi *pcc = input_get_drvdata(dev);
> +
> + if (scancode > ARRAY_SIZE(pcc->keymap))
> + return -EINVAL;
> +
> + if (keycode < 0 || keycode > KEY_MAX)
> + return -EINVAL;
> +
> + pcc->keymap[scancode] = keycode;
You probably want to set_bit the input device here, and also clean up
any now-unused keycodes from there. I'd also suggest sending KEY_PROG1
by default on the CPU throttle button - some users will find it easier
if it already generates a keycode. Other than that, looks good.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2008-07-03 19:23 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-02 9:00 [PATCH] Panasonic Let's Note laptop extras driver Harald Welte
2008-07-02 10:19 ` Matthew Garrett
2008-07-02 13:03 ` Harald Welte
2008-07-02 13:17 ` Matthew Garrett
2008-07-03 16:52 ` Harald Welte
2008-07-03 17:08 ` Matthew Garrett
2008-07-04 3:14 ` Henrique de Moraes Holschuh
2008-07-04 4:43 ` Harald Welte
2008-07-04 11:55 ` Henrique de Moraes Holschuh
2008-07-03 17:35 ` [PATCH] Panasonic Let's Note laptop extras driver v0.93 Harald Welte
2008-07-03 19:23 ` Matthew Garrett [this message]
2008-07-04 1:31 ` Harald Welte
2008-07-04 3:44 ` [PATCH] Panasonic Let's Note laptop extras driver v0.94 Harald Welte
2008-07-04 9:10 ` Matthew Garrett
2008-07-04 12:07 ` Henrique de Moraes Holschuh
2008-07-04 12:11 ` Matthew Garrett
2008-07-04 12:22 ` Henrique de Moraes Holschuh
2008-07-04 12:33 ` Matthew Garrett
2008-07-04 20:18 ` Henrique de Moraes Holschuh
2008-07-12 10:36 ` Harald Welte
2008-07-12 10:56 ` Matthew Garrett
2008-09-22 22:38 ` Len Brown
2008-09-23 15:46 ` Harald Welte
2008-09-24 8:09 ` Len Brown
2008-09-25 4:45 ` SPS 三浦 広志(ＩＴ人材戦略)
2008-09-25 16:44 ` Len Brown
2008-09-26 2:17 ` Hiroshi Miura
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080703192303.GA32260@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=laforge@gnumonks.org \
--cc=linux-acpi@vger.kernel.org \
--cc=miura@da-cha.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.