From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KEXkZ-0007zR-VO for mharc-grub-devel@gnu.org; Thu, 03 Jul 2008 18:58:04 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KEXkY-0007xj-Pm for grub-devel@gnu.org; Thu, 03 Jul 2008 18:58:02 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KEXkX-0007uU-0b for grub-devel@gnu.org; Thu, 03 Jul 2008 18:58:02 -0400 Received: from [199.232.76.173] (port=38250 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KEXkW-0007u6-QI for grub-devel@gnu.org; Thu, 03 Jul 2008 18:58:00 -0400 Received: from aybabtu.com ([69.60.117.155]:48111) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KEXkW-0001u9-B2 for grub-devel@gnu.org; Thu, 03 Jul 2008 18:58:00 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.69) (envelope-from ) id 1KEXgZ-0007UI-4l for grub-devel@gnu.org; Fri, 04 Jul 2008 00:53:55 +0200 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1KEXju-00077f-HV for grub-devel@gnu.org; Fri, 04 Jul 2008 00:57:22 +0200 Date: Fri, 4 Jul 2008 00:57:22 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20080703225722.GC4074@thorin> References: <20080701132532.GA19736@thorin> <20080701153337.GA6154@thorin> <87hcb66cra.fsf@xs4all.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87hcb66cra.fsf@xs4all.nl> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] pc & gpt partmap iterators don't abort when their hook requests it X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Jul 2008 22:58:03 -0000 On Thu, Jul 03, 2008 at 08:31:05PM +0200, Marco Gerards wrote: > Robert Millan writes: > > > On Tue, Jul 01, 2008 at 03:25:32PM +0200, Robert Millan wrote: > >> > >> See ChangeLog for description. I'd really like to receive some review on > >> this one, since the code it touches is so fragile (although I tested it on a > >> typical setup and it works). > > > > Tough luck. Inmediately after this I noticed it breaks grub-setup (I tested it > > by loading core.img directly). > > > > I found a few other callers that relied on the buggy behaviour. Here's a new > > patch. > > Thanks for fixing this. I had a quick look and it looks sane at first > sight. I just committed it (after fixing a pair of mistakes with grub_errno handling). > Did you have a look at the other modules as well? Yes. At first glance, they don't appear to be affected. However, since I can't debug them, I wouldn't want to mess with them anyway. -- Robert Millan I know my rights; I want my phone call! What good is a phone call… if you are unable to speak? (as seen on /.)