All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robert Millan <rmh@aybabtu.com>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] disk/fs_uuid.c
Date: Fri, 4 Jul 2008 01:06:25 +0200	[thread overview]
Message-ID: <20080703230625.GD4074@thorin> (raw)
In-Reply-To: <20080703225021.GA4074@thorin>

[-- Attachment #1: Type: text/plain, Size: 658 bytes --]

On Fri, Jul 04, 2008 at 12:50:21AM +0200, Robert Millan wrote:
> 
> I _did_ extend the search command (before this patch).  The reason for
> providing this is basicaly that it makes grub.cfg more readable (and easier
> to understand), and can't be used outside the context of scripting (for
> example, to set your root/prefix to it, but that would require a patch I
> intend to put together soon).

Basicaly like this;  but it'd have to check that UUID is needed rather than
using it unconditionaly, of course.

-- 
Robert Millan

<GPLv2> I know my rights; I want my phone call!
<DRM> What good is a phone call… if you are unable to speak?
(as seen on /.)

[-- Attachment #2: uuid_boot.diff --]
[-- Type: text/x-diff, Size: 1437 bytes --]

Index: include/grub/i386/pc/kernel.h
===================================================================
--- include/grub/i386/pc/kernel.h	(revision 1686)
+++ include/grub/i386/pc/kernel.h	(working copy)
@@ -41,7 +41,7 @@
 #define GRUB_KERNEL_MACHINE_PREFIX		0x20
 
 /* End of the data section. */
-#define GRUB_KERNEL_MACHINE_DATA_END		0x50
+#define GRUB_KERNEL_MACHINE_DATA_END		0x60
 
 /* The size of the first region which won't be compressed.  */
 #define GRUB_KERNEL_MACHINE_RAW_SIZE		(GRUB_KERNEL_MACHINE_DATA_END + 0x450)
Index: util/i386/pc/grub-install.in
===================================================================
--- util/i386/pc/grub-install.in	(revision 1686)
+++ util/i386/pc/grub-install.in	(working copy)
@@ -232,13 +232,13 @@
 devabstraction_module=`$grub_probe --target=abstraction --device ${grub_device}`
 
 if [ "x${devabstraction_module}" = "x" ] ; then
-    prefix_drive=
+    prefix_drive=\(UUID=`$grub_probe --target=fs_uuid --device ${grub_device}`\)
 else
     prefix_drive=`$grub_probe --target=drive --device ${grub_device}`
 fi
 
 # The order in this list is critical.  Be careful when modifiing it.
-modules="$modules $fs_module $partmap_module biosdisk $devabstraction_module"
+modules="$modules $fs_module $partmap_module biosdisk $devabstraction_module fs_uuid"
 
 $grub_mkimage --output=${grubdir}/core.img \
     --prefix=${prefix_drive}`make_system_path_relative_to_its_root ${grubdir}`/ \

      reply	other threads:[~2008-07-03 23:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-06 16:23 [PATCH] disk/fs_uuid.c Robert Millan
2008-06-26 14:26 ` Robert Millan
2008-07-03 19:05 ` Marco Gerards
2008-07-03 22:50   ` Robert Millan
2008-07-03 23:06     ` Robert Millan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080703230625.GD4074@thorin \
    --to=rmh@aybabtu.com \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.