From mboxrd@z Thu Jan 1 00:00:00 1970 From: Grant Likely Subject: Re: [PATCH v2 3/5] of-bindings: Add binding documentation for SPI bussesand devices Date: Thu, 3 Jul 2008 22:05:50 -0600 Message-ID: <20080704040550.GG12945@secretlab.ca> References: <20080703005749.26187.71719.stgit@trillian.secretlab.ca> <20080703010308.26187.23037.stgit@trillian.secretlab.ca> <58A20A281BAF1047B4EAE68DE5C0BDC2010121B9@zch01exm21.fsl.freescale.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org, linuxppc-dev-mnsaURCQ41sdnm+yROfE0A@public.gmane.org, fabrizio.garetto-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Chen Gong Return-path: Content-Disposition: inline In-Reply-To: <58A20A281BAF1047B4EAE68DE5C0BDC2010121B9-bKEhWGtIRULiD3AT8lUqWFjVikpgYyvb5NbjCUgZEJk@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: linux-spi.vger.kernel.org On Fri, Jul 04, 2008 at 11:59:07AM +0800, Chen Gong wrote: > > + - reg - (required) chip select address of device. > > + - compatible - (required) name of SPI device > > following generic names > > + recommended practice > > + - max-speed - (required) Maximum SPI clocking > > speed of device in Hz > > + - spi,cpol - (optional) Device requires inverse > > clock polarity > > + - spi,cpha - (optional) Device requires shifted > > clock phase > > + - linux,modalias - (optional, Linux specific) Force > > binding of SPI device > > + to a particular spi_device driver. > > Useful for changing > > + driver binding between spidev and a > > kernel SPI driver. > > + > > How about adding a "model" property to describe actual devie type. > Such as using a "sst25vf040b" device with spi-interface, we can > use model="sst25vf040b" to describe it. That's what "compatible" is for. First value in the compatible list is the actual device, followed by devices it is compatible with. In your particular example, the value would be "sst,sst25vf040b" so that it follows device tree conventions. g. ------------------------------------------------------------------------- Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! Studies have shown that voting for your favorite open source project, along with a healthy diet, reduces your potential for chronic lameness and boredom. Vote Now at http://www.sourceforge.net/community/cca08 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from wa-out-1112.google.com (wa-out-1112.google.com [209.85.146.178]) by ozlabs.org (Postfix) with ESMTP id 6AF13DDE03 for ; Fri, 4 Jul 2008 14:06:24 +1000 (EST) Received: by wa-out-1112.google.com with SMTP id n7so664541wag.13 for ; Thu, 03 Jul 2008 21:06:23 -0700 (PDT) Date: Thu, 3 Jul 2008 22:05:50 -0600 From: Grant Likely To: Chen Gong Subject: Re: [PATCH v2 3/5] of-bindings: Add binding documentation for SPI bussesand devices Message-ID: <20080704040550.GG12945@secretlab.ca> References: <20080703005749.26187.71719.stgit@trillian.secretlab.ca> <20080703010308.26187.23037.stgit@trillian.secretlab.ca> <58A20A281BAF1047B4EAE68DE5C0BDC2010121B9@zch01exm21.fsl.freescale.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <58A20A281BAF1047B4EAE68DE5C0BDC2010121B9@zch01exm21.fsl.freescale.net> Sender: Grant Likely Cc: david-b@pacbell.net, linuxppc-dev@ozlabs.org, fabrizio.garetto@gmail.com, linux-kernel@vger.kernel.org, spi-devel-general@lists.sourceforge.net List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Fri, Jul 04, 2008 at 11:59:07AM +0800, Chen Gong wrote: > > + - reg - (required) chip select address of device. > > + - compatible - (required) name of SPI device > > following generic names > > + recommended practice > > + - max-speed - (required) Maximum SPI clocking > > speed of device in Hz > > + - spi,cpol - (optional) Device requires inverse > > clock polarity > > + - spi,cpha - (optional) Device requires shifted > > clock phase > > + - linux,modalias - (optional, Linux specific) Force > > binding of SPI device > > + to a particular spi_device driver. > > Useful for changing > > + driver binding between spidev and a > > kernel SPI driver. > > + > > How about adding a "model" property to describe actual devie type. > Such as using a "sst25vf040b" device with spi-interface, we can > use model="sst25vf040b" to describe it. That's what "compatible" is for. First value in the compatible list is the actual device, followed by devices it is compatible with. In your particular example, the value would be "sst,sst25vf040b" so that it follows device tree conventions. g. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752789AbYGDEGc (ORCPT ); Fri, 4 Jul 2008 00:06:32 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750911AbYGDEGY (ORCPT ); Fri, 4 Jul 2008 00:06:24 -0400 Received: from rv-out-0506.google.com ([209.85.198.236]:58247 "EHLO rv-out-0506.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750868AbYGDEGY (ORCPT ); Fri, 4 Jul 2008 00:06:24 -0400 Date: Thu, 3 Jul 2008 22:05:50 -0600 From: Grant Likely To: Chen Gong Cc: linuxppc-dev@ozlabs.org, spi-devel-general@lists.sourceforge.net, linux-kernel@vger.kernel.org, david-b@pacbell.net, fabrizio.garetto@gmail.com Subject: Re: [PATCH v2 3/5] of-bindings: Add binding documentation for SPI bussesand devices Message-ID: <20080704040550.GG12945@secretlab.ca> References: <20080703005749.26187.71719.stgit@trillian.secretlab.ca> <20080703010308.26187.23037.stgit@trillian.secretlab.ca> <58A20A281BAF1047B4EAE68DE5C0BDC2010121B9@zch01exm21.fsl.freescale.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <58A20A281BAF1047B4EAE68DE5C0BDC2010121B9@zch01exm21.fsl.freescale.net> User-Agent: Mutt/1.5.17+20080114 (2008-01-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 04, 2008 at 11:59:07AM +0800, Chen Gong wrote: > > + - reg - (required) chip select address of device. > > + - compatible - (required) name of SPI device > > following generic names > > + recommended practice > > + - max-speed - (required) Maximum SPI clocking > > speed of device in Hz > > + - spi,cpol - (optional) Device requires inverse > > clock polarity > > + - spi,cpha - (optional) Device requires shifted > > clock phase > > + - linux,modalias - (optional, Linux specific) Force > > binding of SPI device > > + to a particular spi_device driver. > > Useful for changing > > + driver binding between spidev and a > > kernel SPI driver. > > + > > How about adding a "model" property to describe actual devie type. > Such as using a "sst25vf040b" device with spi-interface, we can > use model="sst25vf040b" to describe it. That's what "compatible" is for. First value in the compatible list is the actual device, followed by devices it is compatible with. In your particular example, the value would be "sst,sst25vf040b" so that it follows device tree conventions. g.