From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KEmAo-0000KQ-Sc for mharc-grub-devel@gnu.org; Fri, 04 Jul 2008 10:22:06 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KEmAn-0000KJ-AC for grub-devel@gnu.org; Fri, 04 Jul 2008 10:22:05 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KEmAl-0000K5-TQ for grub-devel@gnu.org; Fri, 04 Jul 2008 10:22:04 -0400 Received: from [199.232.76.173] (port=36453 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KEmAl-0000K2-NY for grub-devel@gnu.org; Fri, 04 Jul 2008 10:22:03 -0400 Received: from aybabtu.com ([69.60.117.155]:40827) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KEmAl-0001p8-Bq for grub-devel@gnu.org; Fri, 04 Jul 2008 10:22:03 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.69) (envelope-from ) id 1KEm6k-0001OZ-0i for grub-devel@gnu.org; Fri, 04 Jul 2008 16:17:54 +0200 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1KEmA9-0000tm-2t for grub-devel@gnu.org; Fri, 04 Jul 2008 16:21:25 +0200 Date: Fri, 4 Jul 2008 16:21:25 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20080704142125.GC2663@thorin> References: <1214929545.13432.19.camel@dv> <1214937759.9353.64.camel@localhost> <20080701204816.GA31206@thorin> <1214954927.9353.91.camel@localhost> <20080702142245.GA21064@thorin> <1215027160.9353.125.camel@localhost> <20080703140211.GA19341@thorin> <1215104875.8123.23.camel@localhost> <20080704000829.GE4074@thorin> <1215135163.26019.44.camel@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1215135163.26019.44.camel@localhost> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: grub-probe detects ext4 wronly as ext2 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Jul 2008 14:22:05 -0000 If you wish to send a patch for the user environment check you proposed, could send it separately? I'm inclined to commit the flag check, but not the environment stuff. Afterwards if you like we could discuss about whether we should be "best-effort" in real GRUB or not. It's really not such a big deal, as long as we don't end up cluttering the user interface because of it. On Fri, Jul 04, 2008 at 03:32:43AM +0200, Javier Martín wrote: > - grub_error (GRUB_ERR_BAD_FS, "not an ext2 filesystem"); > + grub_error (GRUB_ERR_BAD_FS, "not an ext2 filesystem, or incompatible" > + "features enabled (extents, etc.)"); I would avoid referring explicitly to the features involved, because it means the message will end up being obsolete when extents are supported (and we will likely forget to update it). -- Robert Millan I know my rights; I want my phone call! What good is a phone call… if you are unable to speak? (as seen on /.)