From: Theodore Tso <tytso@mit.edu>
To: Arjan van de Ven <arjan@infradead.org>
Cc: akpm@linux-foundation.org, jens.axboe@oracle.com,
linux-kernel@vger.kernel.org
Subject: Re: PATCH] fix potential latency issues in JBD's journal code
Date: Sat, 5 Jul 2008 10:13:35 -0400 [thread overview]
Message-ID: <20080705141335.GB20240@mit.edu> (raw)
In-Reply-To: <20080704192929.2c4dd4ca@infradead.org>
Acked-by: "Theodore Ts'o" <tytso@mit.edu>
I will make the corresponding change for ext4. Is the "Properly
notify block layer of sync writes" going to be pushed to mainline? I
can't add SWRITE_SYNC to the ext4 tree without growing a dependency to
this patch.
> This patch modifies two key places that submit IO that then immediately will
> get waited on. The JBD code is slightly convoluted, but after some chasing of
> abstraction layers, these instances seem to really be of this pattern.
> There's one case in checkpoint.c which is another candidate, but I've not
> been able to get my head around the code enough to verify that that one
> really is of this pattern as well, so for now I'll leave that one as is.
You mean the ll_rw_block() SWRITE in __flush_patch? Yep, seems to be
of the same pattern.
- Ted
next prev parent reply other threads:[~2008-07-05 14:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-05 2:29 PATCH] fix potential latency issues in JBD's journal code Arjan van de Ven
2008-07-05 5:00 ` Arjan van de Ven
2008-07-05 14:13 ` Theodore Tso [this message]
2008-07-05 15:18 ` Arjan van de Ven
2008-07-06 4:15 ` Theodore Tso
2008-07-06 5:30 ` Arjan van de Ven
2008-07-06 12:20 ` Theodore Tso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080705141335.GB20240@mit.edu \
--to=tytso@mit.edu \
--cc=akpm@linux-foundation.org \
--cc=arjan@infradead.org \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.