All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ivo van Doorn <ivdoorn@gmail.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Bryan Batten <BryanBatten@sbcglobal.net>,
	linville@tuxdriver.com,
	linux-wireless <linux-wireless@vger.kernel.org>,
	rt2400-devel@lists.sourceforge.net
Subject: Re: [Rt2400-devel] [PATCH] rt2x00: Fix NULL pointer error in	adhoc/master mode
Date: Sat, 5 Jul 2008 21:26:16 +0200	[thread overview]
Message-ID: <200807052126.16913.IvDoorn@gmail.com> (raw)
In-Reply-To: <1215283415.6848.14.camel@johannes.berg>

On Saturday 05 July 2008, Johannes Berg wrote:
> 
> > Hmm, in that case I have to fix something in the beacondone handler
> > to prevent it requesting a beacon when mac80211 hasn't supplied anything
> > yet..
> 
> I was working in this area... Can you take a quick look at this patch
> and let me know what you think?
> http://johannes.sipsolutions.net/patches/kernel/all/2008-07-05-18%3a42/mac80211-beacon-revamp.patch

Patch looks good to me, it wouldn't change anything about the above since t2x00 would still
call ieee80211_beacon_get() when the beacon wasn't provided by mac80211 yet.

But the flags that mark what has changed is definately a good idea,
that will prevent some redundant register writes. :)

Ivo

  reply	other threads:[~2008-07-05 19:19 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-05 13:11 [PATCH] rt2x00: Fix NULL pointer error in adhoc/master mode Ivo van Doorn
2008-07-05 18:33 ` [Rt2400-devel] " Bryan Batten
2008-07-05 18:42   ` Ivo van Doorn
2008-07-05 18:43     ` Johannes Berg
2008-07-05 19:26       ` Ivo van Doorn [this message]
2008-07-05 19:22         ` Johannes Berg
2008-07-05 19:37           ` Ivo van Doorn
2008-07-05 19:37             ` Johannes Berg
2008-07-05 21:17               ` Ivo van Doorn
2008-07-05 20:25     ` Bryan Batten
2008-07-05 21:19       ` Ivo van Doorn
2008-07-09 17:59     ` Bryan Batten
2008-07-09 18:29       ` Ivo van Doorn
2008-07-09 18:33         ` Bryan Batten

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200807052126.16913.IvDoorn@gmail.com \
    --to=ivdoorn@gmail.com \
    --cc=BryanBatten@sbcglobal.net \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=rt2400-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.