From: Al Viro <viro@ZenIV.linux.org.uk>
To: Marcin Slusarz <marcin.slusarz@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Frans Pop <elendil@planet.nl>,
"Eric W. Biederman" <ebiederm@xmission.com>
Subject: Re: [PATCH] parport/ppdev: fix registration of sysctl entries
Date: Sun, 6 Jul 2008 01:11:48 +0100 [thread overview]
Message-ID: <20080706001148.GX28946@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20080705235148.GW28946@ZenIV.linux.org.uk>
On Sun, Jul 06, 2008 at 12:51:48AM +0100, Al Viro wrote:
> I don't believe that it's right. Note that if you *do* race there, you
> are fucked regardless of sysctls - ppdev.c::register_device() racing
> with itself will do tons of fun things all by itself (starting with two
> threads allocating different pdev and both setting pp->pdev).
>
> IOW, *if* that's what we are hitting here, you've only papered over the
> visible symptom.
BTW, with your patch you'll have 100% reproducible double registration if
you do PPCLAIM/PPRELEASE/PPCLAIN on one file descriptor.
next prev parent reply other threads:[~2008-07-06 0:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-05 13:21 [PATCH] parport/ppdev: fix registration of sysctl entries Marcin Slusarz
2008-07-05 23:51 ` Al Viro
2008-07-06 0:11 ` Al Viro [this message]
2008-07-06 4:05 ` Al Viro
2008-07-06 6:49 ` Eric W. Biederman
2008-07-06 8:11 ` Al Viro
2008-07-06 9:25 ` Eric W. Biederman
2008-07-06 16:22 ` Eduard - Gabriel Munteanu
2008-07-06 16:08 ` Alan Cox
2008-07-06 17:00 ` Eduard - Gabriel Munteanu
2008-07-06 18:09 ` Alan Cox
2008-07-06 15:12 ` Marcin Slusarz
2008-07-06 15:07 ` Marcin Slusarz
2008-07-06 16:01 ` Arjan van de Ven
2008-07-06 20:35 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080706001148.GX28946@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=ebiederm@xmission.com \
--cc=elendil@planet.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=marcin.slusarz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.