From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KFZ1G-0007oJ-5q for mharc-grub-devel@gnu.org; Sun, 06 Jul 2008 14:31:30 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KFZ1D-0007nU-QR for grub-devel@gnu.org; Sun, 06 Jul 2008 14:31:27 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KFZ1C-0007mu-R0 for grub-devel@gnu.org; Sun, 06 Jul 2008 14:31:27 -0400 Received: from [199.232.76.173] (port=35189 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KFZ1C-0007mq-NK for grub-devel@gnu.org; Sun, 06 Jul 2008 14:31:26 -0400 Received: from aybabtu.com ([69.60.117.155]:55815) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KFZ1C-0007Za-EV for grub-devel@gnu.org; Sun, 06 Jul 2008 14:31:26 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.69) (envelope-from ) id 1KFYww-0005TB-Iq for grub-devel@gnu.org; Sun, 06 Jul 2008 20:27:03 +0200 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1KFZ0U-0005lN-PO for grub-devel@gnu.org; Sun, 06 Jul 2008 20:30:42 +0200 Date: Sun, 6 Jul 2008 20:30:42 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20080706183042.GA22023@thorin> References: <1215264476.26019.160.camel@localhost> <1215293427.17114.2.camel@dv> <1215298499.26019.192.camel@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1215298499.26019.192.camel@localhost> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: Endianness macros capitalization X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 06 Jul 2008 18:31:28 -0000 On Sun, Jul 06, 2008 at 12:54:58AM +0200, Javier Martín wrote: > El sáb, 05-07-2008 a las 17:30 -0400, Pavel Roskin escribió: > > They probably should be functions. We may want to sparse annotate GRUB > > one day, and then inline functions in the only way to go. > Hmm... you mean changing this > > #define grub_swap_bytes16(x) \ > ({ \ > grub_uint16_t _x = (x); \ > (grub_uint16_t) ((_x << 8) | (_x >> 8)); \ > }) > > ...for this > > inline grub_uint16_t grub_swap_bytes16(uint16_t x) > { > return (x << 8) | (x >> 8); > } I know I get to be annoying about this, but which of these two (plus the non-inline version) would result in _smaller_ code? Function calls on i386-pc are cheap (because we use the regparm hack), so maybe it'd work better using normal functions. -- Robert Millan I know my rights; I want my phone call! What good is a phone call… if you are unable to speak? (as seen on /.)