From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KFZBv-0005hN-4K for mharc-grub-devel@gnu.org; Sun, 06 Jul 2008 14:42:31 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KFZBt-0005h6-HS for grub-devel@gnu.org; Sun, 06 Jul 2008 14:42:29 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KFZBs-0005gu-JA for grub-devel@gnu.org; Sun, 06 Jul 2008 14:42:28 -0400 Received: from [199.232.76.173] (port=40817 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KFZBs-0005gr-FU for grub-devel@gnu.org; Sun, 06 Jul 2008 14:42:28 -0400 Received: from aybabtu.com ([69.60.117.155]:45839) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KFZBs-0000VR-0O for grub-devel@gnu.org; Sun, 06 Jul 2008 14:42:28 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.69) (envelope-from ) id 1KFZ7c-0005U8-U4; Sun, 06 Jul 2008 20:38:05 +0200 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1KFZBD-0005rA-Va; Sun, 06 Jul 2008 20:41:47 +0200 Date: Sun, 6 Jul 2008 20:41:47 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20080706184147.GE22023@thorin> References: <891e76af0806291928r242db017wd0891a67f2301e68@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <891e76af0806291928r242db017wd0891a67f2301e68@mail.gmail.com> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Cc: Lucas Gadani Subject: Re: [PATCH] Fix chainloding + Chainloading into logical partitions X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 06 Jul 2008 18:42:30 -0000 On Mon, Jun 30, 2008 at 02:28:24AM +0000, Lucas Gadani wrote: > Hello, > > This is my first patch for GRUB, and I haven't found any coding > styles/formatting, nor developer documentation, so, if there's > something wrong, please, forgive me and point me to the right > direction. > > Current implementation of the chainloading code does not work, cause > it reads the partition table from the first sector of the root device, > and the root device does not contain partition information. I've > changed the way partition table are loaded, keeping a copy of the > partition entry in grub_partition_t structs data field, and just > loading this information in the correct address when chainloading. > I've also changed the logical partitions start address to point to the > actual disk sector, instead of pointing to the sector relative to the > beginning of the extended partition, so we can now boot into logical > partitions (for example, syslinux doesn't boot if the partition table > doesn't map to the correct disk sector). > > Any comments are appreciated. Looks like it increases pc.mod code to store information that is only useful to the chainloader. Is there a reason for not having the chainloader retrieve it? (note that for disk access we have a cache) -- Robert Millan I know my rights; I want my phone call! What good is a phone call… if you are unable to speak? (as seen on /.)