From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] Fix a missing include for the lwmon5 dspic init POST.
Date: Mon, 7 Jul 2008 09:58:14 +0200 [thread overview]
Message-ID: <200807070958.14255.sr@denx.de> (raw)
In-Reply-To: <20080530093411.291532430A@gemini.denx.de>
On Friday 30 May 2008, Wolfgang Denk wrote:
> In message <12121336692773-git-send-email-sascha.laue@liebherr.com> you
> wrote: ...
>
> > - while (!gpio_read_in_bit(CFG_GPIO_DSPIC_READY) && reg++ < 1000) {
> > + while (gpio_read_in_bit(CFG_GPIO_DSPIC_READY) && reg++ < 1000) {
> > udelay(1000);
> > }
> > - gpio_write_bit(CFG_GPIO_HIGHSIDE, 0);
> > if (gpio_read_in_bit(CFG_GPIO_DSPIC_READY)) {
> > /* set "boot error" flag */
> > out_be32((void *)CFG_DSPIC_TEST_ADDR,
> > in_be32((void *)CFG_DSPIC_TEST_ADDR) |
> > CFG_DSPIC_TEST_MASK);
> > + } else {
> > + /* dspic ready - disable LSB transmitter */
> > + gpio_write_bit(CFG_GPIO_HIGHSIDE, 0);
>
> Description and patch don't match. Please fix.
Sascha, any updates here?
Thanks.
Best regards,
Stefan
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================
prev parent reply other threads:[~2008-07-07 7:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-30 7:47 [U-Boot-Users] [PATCH] Fix a missing include for the lwmon5 dspic init POST sascha.laue at liebherr.com
2008-05-30 9:34 ` Wolfgang Denk
2008-07-07 7:58 ` Stefan Roese [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200807070958.14255.sr@denx.de \
--to=sr@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.