From: David Miller <davem@davemloft.net>
To: den@openvz.org
Cc: containers@lists.osdl.org, netdev@vger.kernel.org, ebiederm@xmission.com
Subject: Re: [PATCH net-next 3/9] ipv4: remove static flush_delay variable
Date: Tue, 08 Jul 2008 03:05:59 -0700 (PDT) [thread overview]
Message-ID: <20080708.030559.209246943.davem@davemloft.net> (raw)
In-Reply-To: <1215429974.29879.84.camel@iris.sw.ru>
From: "Denis V. Lunev" <den@openvz.org>
Date: Mon, 07 Jul 2008 15:26:14 +0400
> On Mon, 2008-07-07 at 01:43 -0700, Eric W. Biederman wrote:
> > "Denis V. Lunev" <den@openvz.org> writes:
> >
> > > flush delay is used as an external storage for net.ipv4.route.flush sysctl
> > > entry. It is write-only.
> > >
> > > The ctl_table->data for this entry is used once. Fix this case to point
> > > to the stack to remove global variable. Do this to avoid additional
> > > variable on struct net in the next patch.
> > >
> > > Possible race (as it was before) accessing this local variable is removed
> > > using flush_mutex.
> >
> > FYI. You can avoid the locking entirely by defining a local struct ctl_table variable
> > on the stack.
>
> Dave, could you consider the patch attached?
Applied to net-next-2.6, thanks!
next prev parent reply other threads:[~2008-07-08 10:05 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-04 13:16 [PATCH net-next 0/9] selective (per/namespace) flush of rt_cache Denis V. Lunev
2008-07-04 13:17 ` [PATCH net-next 1/9] netns: add namespace parameter to rt_cache_flush Denis V. Lunev
2008-07-04 13:17 ` [PATCH net-next 2/9] net: add fib_rules_ops to flush_cache method Denis V. Lunev
2008-07-04 13:17 ` [PATCH net-next 3/9] ipv4: remove static flush_delay variable Denis V. Lunev
2008-07-07 8:43 ` Eric W. Biederman
2008-07-07 11:26 ` Denis V. Lunev
2008-07-07 11:26 ` Denis V. Lunev
2008-07-08 10:05 ` David Miller [this message]
2008-07-04 13:17 ` [PATCH net-next 4/9] netns: register net.ipv4.route.flush in each namespace Denis V. Lunev
2008-07-04 13:17 ` [PATCH net-next 5/9] netns: make rt_secret_rebuild timer per namespace Denis V. Lunev
2008-07-04 13:17 ` [PATCH net-next 6/9] netns: add struct net parameter to rt_cache_invalidate Denis V. Lunev
2008-07-04 13:17 ` [PATCH net-next 7/9] ipv4: pass current value of rt_genid into rt_hash Denis V. Lunev
2008-07-04 13:17 ` [PATCH net-next 8/9] netns: place rt_genid into struct net Denis V. Lunev
2008-07-04 13:17 ` [PATCH net-next 9/9] netns: selective flush of rt_cache Denis V. Lunev
[not found] ` <1215177360.27873.50.camel-aPCOdVxUTlgvJsYlp49lxw@public.gmane.org>
2008-07-06 3:55 ` [PATCH net-next 0/9] selective (per/namespace) " David Miller
2008-07-07 10:29 ` Eric W. Biederman
2008-07-07 10:39 ` Denis V. Lunev
2008-07-07 10:51 ` Denis V. Lunev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080708.030559.209246943.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=containers@lists.osdl.org \
--cc=den@openvz.org \
--cc=ebiederm@xmission.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.