From: Hamish Moffatt <hamish@cloud.net.au>
To: buildroot@busybox.net
Subject: [Buildroot] query about change to $(MAKE) definition
Date: Tue, 8 Jul 2008 17:10:48 +1000 [thread overview]
Message-ID: <20080708071048.GA23482@cloud.net.au> (raw)
Peter,
Can you explain the rationale behind the following change to
package/Makefile.in you made last week?
It's causing my kernel builds to be very noisy now. I have a custom
makefile for my kernel build, and I'm now getting a ton of
make[5]: warning: -jN forced in submake: disabling jobserver mode.
warnings from it, because $(MAKE) has changed from
'/usr/bin/make -j2' to: '/usr/bin/make MAKE=/usr/bin/make -j2'.
So now -j2 is passed to every submake instance, rather than letting make
itself do the right thing. I'm guessing other builds that do anything
tricky might also suffer.
Thanks
Hamish
Index: package/Makefile.in
===================================================================
--- package/Makefile.in (revision 22589)
+++ package/Makefile.in (revision 22590)
@@ -6,15 +6,14 @@
endif
HOSTMAKE :=$(shell $(CONFIG_SHELL) -c "which $(HOSTMAKE)" || type -p $(HOSTMAKE) || echo make)
-MAKE1:=$(HOSTMAKE) MAKE="$(firstword $(HOSTMAKE)) -j1"
-MAKE:=$(HOSTMAKE) -j$(BR2_JLEVEL)
-
# honor silent mode
ifeq (s,$(findstring s,$(MAKEFLAGS)))
-MAKE1+= -s
-MAKE+= -s
+MAKESILENT:=-s
endif
+MAKE1:=$(HOSTMAKE) MAKE='$(firstword $(HOSTMAKE)) -j1 $(MAKESILENT)'
+MAKE:=$(HOSTMAKE) MAKE='$(firstword $(HOSTMAKE)) -j$(BR2_JLEVEL) $(MAKESILENT)'
+
ifeq ($(BR2_OPTIMIZE_0),y)
TARGET_OPTIMIZATION=-O0
endif
--
Hamish Moffatt VK3SB <hamish@debian.org> <hamish@cloud.net.au>
next reply other threads:[~2008-07-08 7:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-08 7:10 Hamish Moffatt [this message]
2008-07-08 8:16 ` [Buildroot] query about change to $(MAKE) definition Peter Korsgaard
2008-07-08 8:26 ` Bernhard Fischer
2008-07-08 9:02 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080708071048.GA23482@cloud.net.au \
--to=hamish@cloud.net.au \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.