From: Gleb Natapov <gleb@qumranet.com>
To: Paul Brook <paul@codesourcery.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 2/3] Fix time drift problem under high load when PIT is in use.
Date: Tue, 8 Jul 2008 17:42:46 +0300 [thread overview]
Message-ID: <20080708144246.GA11711@minantech.com> (raw)
In-Reply-To: <200807081452.52152.paul@codesourcery.com>
On Tue, Jul 08, 2008 at 02:52:51PM +0100, Paul Brook wrote:
> On Tuesday 08 July 2008, Gleb Natapov wrote:
> > Count the number of interrupts that was lost due to interrupt coalescing
> > and re-inject them back when possible. This fixes time drift problem when
> > pit is used as a time source.
>
> You apparently ignored my comments about not doing this when we have an
> accurate virtual clock.
>
What part do you want me to disable if virtual clock is enabled?
Interrupt re-injection in PIT/RTC code? Or do you what qemu_irq_set() to
always return 1 if virtual clock is enabled (this will effectively
disable the new interface and all its users will fall back to current
behaviour).
--
Gleb.
next prev parent reply other threads:[~2008-07-08 14:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-08 11:15 [Qemu-devel] [PATCH v2 0/3] Fix guest time drift under heavy load Gleb Natapov
2008-07-08 11:15 ` [Qemu-devel] [PATCH v2 1/3] Change qemu_set_irq() to return status information Gleb Natapov
2008-07-08 11:15 ` [Qemu-devel] [PATCH v2 2/3] Fix time drift problem under high load when PIT is in use Gleb Natapov
2008-07-08 13:52 ` Paul Brook
2008-07-08 14:42 ` Gleb Natapov [this message]
2008-07-08 11:15 ` [Qemu-devel] [PATCH v2 3/3] Fix time drift problem under high load when RTC " Gleb Natapov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080708144246.GA11711@minantech.com \
--to=gleb@qumranet.com \
--cc=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.