From: Joel Becker <Joel.Becker@oracle.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH 3/4] ocfs2: Fixes tiny race between mount and recovery
Date: Tue, 8 Jul 2008 11:17:06 -0700 [thread overview]
Message-ID: <20080708181706.GA13557@mail.oracle.com> (raw)
In-Reply-To: <48739F16.7000205@oracle.com>
On Tue, Jul 08, 2008 at 10:08:38AM -0700, Sunil Mushran wrote:
> Instead of using generation, we could use ij_pad. Renamed to
> something appropriate.
I like that, as it is specific to the journal part and leaves
i_generation alone. Can we see ourselves needing any other use of that
word?
Joel
> Sunil Mushran wrote:
>> Possible Solution:
>> Use the i_generation in the journal inode as a recovery counter.
>> Meaning, we increment it each time we recover the journal. That
>> is, from mount thread in ocfs2_journal_load() and from recovery
>> thread in ocfs2_replay_journal(). In both places, we have the
>> superblock lock making the writes safe.
--
"When ideas fail, words come in very handy."
- Goethe
Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127
next prev parent reply other threads:[~2008-07-08 18:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-07 20:26 [Ocfs2-devel] Four patches for ocfs2 1.4 Sunil Mushran
2008-07-07 20:26 ` [Ocfs2-devel] [PATCH 1/4] ocfs2: Silence an error message in ocfs2_file_aio_read() Sunil Mushran
2008-07-07 20:26 ` [Ocfs2-devel] [PATCH 2/4] ocfs2: Change the recovery map to an array of node numbers Sunil Mushran
2008-07-07 20:26 ` [Ocfs2-devel] [PATCH 3/4] ocfs2: Fixes tiny race between mount and recovery Sunil Mushran
2008-07-07 20:50 ` Joel Becker
[not found] ` <4872C7A4.1010507@oracle.com>
2008-07-08 17:08 ` Sunil Mushran
2008-07-08 18:17 ` Joel Becker [this message]
2008-07-09 17:35 ` Mark Fasheh
2008-07-09 18:29 ` Joel Becker
2008-07-07 20:51 ` Joel Becker
2008-07-07 20:26 ` [Ocfs2-devel] [PATCH 4/4] ocfs2/dlm: Fixes oops in dlm_new_lockres() Sunil Mushran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080708181706.GA13557@mail.oracle.com \
--to=joel.becker@oracle.com \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.