All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Cc: linux-ide@vger.kernel.org, mcherkashin@ru.mvista.com
Subject: Re: [PATCH] palm_bk3710: fix IDECLK period calculation
Date: Tue, 8 Jul 2008 19:18:38 +0200	[thread overview]
Message-ID: <200807081918.41190.bzolnier@gmail.com> (raw)
In-Reply-To: <200807081829.06199.sshtylyov@ru.mvista.com>

On Tuesday 08 July 2008, Sergei Shtylyov wrote:
> The driver uses completely bogus rounding formula for calculating period from
> the IDECLK frequency which gives one-off period values (e.g. 11 ns with 100 MHz
> IDECLK) which in turn can lead to overclocked IDE transfer timings.  Actually,
> rounding is just wrong in this case, so use a mere division for a safe result.
> 
> While at it, also:
> 
> - give 'ide_palm_clk' variable a more suitable name;
> 
> - get rid of the useless 'ideclkp' variable;
> 
> - drop the LISP stype 'p' postfix from the 'clkp' variable's name. :-)
> 
> Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>

applied, thanks

  reply	other threads:[~2008-07-08 17:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-08 14:29 [PATCH] palm_bk3710: fix IDECLK period calculation Sergei Shtylyov
2008-07-08 17:18 ` Bartlomiej Zolnierkiewicz [this message]
2008-07-09 14:46 ` Sergei Shtylyov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200807081918.41190.bzolnier@gmail.com \
    --to=bzolnier@gmail.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=mcherkashin@ru.mvista.com \
    --cc=sshtylyov@ru.mvista.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.