From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Roese Date: Wed, 9 Jul 2008 08:16:33 +0200 Subject: [U-Boot-Users] [PATCH] pci: Move PCI device configuration check into a separate weak function In-Reply-To: <29ab51dc0807082307m33644dccxfcd3cc4110571cb9@mail.gmail.com> References: <1215511307-25645-1-git-send-email-sr@denx.de> <200807090733.28950.sr@denx.de> <29ab51dc0807082307m33644dccxfcd3cc4110571cb9@mail.gmail.com> Message-ID: <200807090816.33491.sr@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wednesday 09 July 2008, Nobuhiro Iwamatsu wrote: > >> When PCI_BDF was 0,0,0, does the board of PPC have the device which > >> do not want to initialize? > > > > This is the current situation, yes. At least on PPC4xx. With this new > > patch all platforms can overwrite this default behavior without breaking > > backward compatibility. > > OK, I see. > > > Does it work for you? > > Work fine. Thank you. OK. > But I have suggestion. > > If these cords depend on PPC4xx and other PPC platform, I think that move > these code to PPC platform. > Do you think this suggestion? I don't know if this current implementation only works for PPC. Its used on all platforms using this PCI code right now. So I think we should keep this version in this file as default behavior. Best regards, Stefan ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de =====================================================================