Re: [PATCH 02/08]: vlan: deliver packets received with VLAN acceleration to network taps

[Ben Hutchings <bhutchings@solarflare.com>]

Patrick McHardy wrote:
> vlan: deliver packets received with VLAN acceleration to network taps
> 
> When VLAN header stripping is used, packets currently bypass packet
> sockets (and other network taps) completely. For locally existing
> VLANs, they appear directly on the VLAN device, for unknown VLANs
> they are silently dropped.
> 
> Add a new function netif_nit_deliver() to deliver incoming packets
> to all network interface taps and use it in __vlan_hwaccel_rx() to
> make VLAN packets visible on the underlying device.
[...]
> +/*
> + * 	netif_tap_deliver - deliver received packets to network taps
> + * 	@skb: buffer
> + *
> + * 	This function is used to deliver incoming packets to network
> + * 	taps. It should be used when the normal netif_receive_skb path
> + * 	is bypassed, for example because of VLAN acceleration.
> + */
> +void netif_nit_deliver(struct sk_buff *skb)
[...]

Is it supposed to be called netif_nit_deliver() or netif_tap_deliver()?

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.