All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@suse.cz>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0 of 2] fbcon: blinking text fix and implementation
Date: Wed, 9 Jul 2008 16:47:05 +0200	[thread overview]
Message-ID: <20080709144704.GA11006@ucw.cz> (raw)
In-Reply-To: <486A4F5F.7030506@eu.citrix.com>

On Tue 2008-07-01 16:38:07, Stefano Stabellini wrote:
> Hi all,
> I have recently found out that there is a small bug in fbcon handling
> the background color.
> The forth bit of the background color is the blink property bit, not the
> intensity bit, as for the foreground color.
> Therefore it shouldn't be included in the background color.
> I also wrote a very simple implementation for blinking text in fbcon,
> using the flashcursor function to scan the buffer for blinking chars.
> Any suggestion or critic is very welcome, but don't be too hard :)

I'd prefer to call that 'feature' and leave it alone. Burning cpu
power to provide annoying blinking text is at least questionable...

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

  reply	other threads:[~2008-07-09 14:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-01 15:38 [PATCH 0 of 2] fbcon: blinking text fix and implementation Stefano Stabellini
2008-07-09 14:47 ` Pavel Machek [this message]
2008-07-09 15:22   ` Stefano Stabellini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080709144704.GA11006@ucw.cz \
    --to=pavel@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stefano.stabellini@eu.citrix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.