From: Michael Buesch <mb@bu3sch.de>
To: Ivo van Doorn <ivdoorn@gmail.com>
Cc: Johannes Berg <johannes@sipsolutions.net>,
"John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org,
rt2400-devel@lists.sourceforge.net
Subject: Re: [PATCH 1/3] mac80211: Include sequence number in IBSS and Mesh beacons
Date: Wed, 9 Jul 2008 17:15:24 +0200 [thread overview]
Message-ID: <200807091715.24710.mb@bu3sch.de> (raw)
In-Reply-To: <200807091708.04870.IvDoorn@gmail.com>
On Wednesday 09 July 2008 17:08:04 Ivo van Doorn wrote:
> On Wednesday 09 July 2008, Johannes Berg wrote:
> >
> > > If rt2x00 would use a global lock to block all TX and beacons, then yes.
> > > But rt2x00 uses per-queue locking. When a beacon is being updated rt2x00
> > > will still allow regular frames to be queued.
> >
> > That just widens the window. And if you have multiple queues then you
> > can't do sw sequence numbers anyway because the hardware might reorder
> > the frames.
>
> That doesn't seem to be a problem in the legacy drivers, so I guess the hardware
> does *something* to prevent problems.
Well, legacy drivers don't use mac80211. Sequence counting can trivially be fixed
by doing it _right_ before queueing the packet to the hardware in the driver,
with the TX queue lock held, that must already be there.
--
Greetings Michael.
next prev parent reply other threads:[~2008-07-09 15:15 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-09 13:11 [PATCH 0/3] rt2x00 update Ivo van Doorn
2008-07-09 13:11 ` [PATCH 1/3] mac80211: Include sequence number in IBSS and Mesh beacons Ivo van Doorn
2008-07-09 13:12 ` [PATCH 2/3] rt2x00: Add support for CTS protection in rt2x00lib Ivo van Doorn
2008-07-09 13:12 ` [PATCH 3/3] rt2x00: Reorganize beacon handling Ivo van Doorn
2008-07-09 13:14 ` [PATCH 1/3] mac80211: Include sequence number in IBSS and Mesh beacons Johannes Berg
2008-07-09 13:38 ` Michael Buesch
2008-07-09 13:41 ` Johannes Berg
2008-07-09 14:04 ` Ivo van Doorn
2008-07-09 13:58 ` Johannes Berg
2008-07-09 14:57 ` Ivo van Doorn
2008-07-09 14:49 ` Johannes Berg
2008-07-09 14:00 ` Michael Buesch
2008-07-09 14:05 ` Johannes Berg
2008-07-09 14:37 ` Ivo van Doorn
2008-07-09 14:48 ` Johannes Berg
2008-07-09 15:08 ` Ivo van Doorn
2008-07-09 15:15 ` Michael Buesch [this message]
2008-07-09 15:36 ` Ivo van Doorn
2008-07-09 15:33 ` Johannes Berg
2008-07-09 15:48 ` Ivo van Doorn
2008-07-09 15:49 ` Johannes Berg
2008-07-09 15:55 ` Johannes Berg
2008-07-09 16:12 ` Ivo van Doorn
2008-07-09 17:42 ` Johannes Berg
2008-07-09 18:12 ` Ivo van Doorn
2008-07-09 18:07 ` Johannes Berg
2008-07-09 16:08 ` Ivo van Doorn
2008-07-09 16:07 ` Johannes Berg
2008-07-09 15:16 ` Johannes Berg
2008-07-09 15:12 ` Michael Buesch
2008-07-14 18:49 ` John W. Linville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200807091715.24710.mb@bu3sch.de \
--to=mb@bu3sch.de \
--cc=ivdoorn@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=rt2400-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.