From: Samuel Ortiz <sameo@openedhand.com>
To: Philipp Zabel <philipp.zabel@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mfd: remove DS1WM register definitions from asic3.h
Date: Thu, 10 Jul 2008 02:30:55 +0200 [thread overview]
Message-ID: <20080710003054.GC2637@sortiz.org> (raw)
In-Reply-To: <1215289005.23398.36.camel@localhost.localdomain>
On Sat, Jul 05, 2008 at 10:16:45PM +0200, Philipp Zabel wrote:
> There is a dedicated ds1wm driver, no need to duplicate this
> information here.
>
> Signed-off-by: Philipp Zabel <philipp.zabel@gmail.com>
Applied, thanks.
> ---
> include/linux/mfd/asic3.h | 38 +++-----------------------------------
> 1 files changed, 3 insertions(+), 35 deletions(-)
>
> diff --git a/include/linux/mfd/asic3.h b/include/linux/mfd/asic3.h
> index 0eae308..8f8c46c 100644
> --- a/include/linux/mfd/asic3.h
> +++ b/include/linux/mfd/asic3.h
> @@ -265,44 +265,12 @@ struct asic3_platform_data {
> #define ASIC3_EXTCF_CF_SLEEP (1 << 15) /* CF sleep mode control */
>
> /*********************************************
> - * The Onewire interface registers
> - *
> - * OWM_CMD
> - * OWM_DAT
> - * OWM_INTR
> - * OWM_INTEN
> - * OWM_CLKDIV
> + * The Onewire interface (DS1WM) is handled
> + * by the ds1wm driver.
> *
> *********************************************/
>
> -#define ASIC3_OWM_Base 0xC00
> -
> -#define ASIC3_OWM_CMD 0x00
> -#define ASIC3_OWM_DAT 0x04
> -#define ASIC3_OWM_INTR 0x08
> -#define ASIC3_OWM_INTEN 0x0C
> -#define ASIC3_OWM_CLKDIV 0x10
> -
> -#define ASIC3_OWM_CMD_ONEWR (1 << 0)
> -#define ASIC3_OWM_CMD_SRA (1 << 1)
> -#define ASIC3_OWM_CMD_DQO (1 << 2)
> -#define ASIC3_OWM_CMD_DQI (1 << 3)
> -
> -#define ASIC3_OWM_INTR_PD (1 << 0)
> -#define ASIC3_OWM_INTR_PDR (1 << 1)
> -#define ASIC3_OWM_INTR_TBE (1 << 2)
> -#define ASIC3_OWM_INTR_TEMP (1 << 3)
> -#define ASIC3_OWM_INTR_RBF (1 << 4)
> -
> -#define ASIC3_OWM_INTEN_EPD (1 << 0)
> -#define ASIC3_OWM_INTEN_IAS (1 << 1)
> -#define ASIC3_OWM_INTEN_ETBE (1 << 2)
> -#define ASIC3_OWM_INTEN_ETMT (1 << 3)
> -#define ASIC3_OWM_INTEN_ERBF (1 << 4)
> -
> -#define ASIC3_OWM_CLKDIV_PRE (3 << 0) /* two bits wide at bit 0 */
> -#define ASIC3_OWM_CLKDIV_DIV (7 << 2) /* 3 bits wide at bit 2 */
> -
> +#define ASIC3_OWM_BASE 0xC00
>
> /*****************************************************************************
> * The SD configuration registers are at a completely different location
> --
> 1.5.6
>
>
prev parent reply other threads:[~2008-07-10 0:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-05 20:16 [PATCH] mfd: remove DS1WM register definitions from asic3.h Philipp Zabel
2008-07-10 0:30 ` Samuel Ortiz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080710003054.GC2637@sortiz.org \
--to=sameo@openedhand.com \
--cc=linux-kernel@vger.kernel.org \
--cc=philipp.zabel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.