From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Daniel P. Berrange" Subject: Re: ioemu build failure with GCC > 4.3 Date: Thu, 10 Jul 2008 10:43:17 +0100 Message-ID: <20080710094317.GE23601@redhat.com> References: <37E52D09333DE2469A03574C88DBF40F021BEF97@pdsmsx414.ccr.corp.intel.com> Reply-To: "Daniel P. Berrange" Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Keir Fraser Cc: xen-devel@lists.xensource.com, ian.jackson@eu.citrix.com, "He, Qing" List-Id: xen-devel@lists.xenproject.org On Thu, Jul 10, 2008 at 10:39:31AM +0100, Keir Fraser wrote: > On 10/7/08 10:32, "He, Qing" wrote: > > > It's most straightforward to remove `inline' in slirp/misc.c, the code > > doesn't really seem to benefit from it. But it looks pretty old and not > > maintained for sometime. What about patch it locally? > > > > Other options include specify `-fgnu89-inline' (n/a prior to GCC 4.1.3) > > and overrides slirp compile line with `-std=gnu89', but may not be > > preferred. > > Could we change the '#define inline' in slirp_config.h to define it to > nothing? None of the usages of 'inline' in the slirp directory look like a > particularly good idea. None of the entire slirp directory looks like a good idea. This code isn't even used in Xen is it ? My vote would be disabling compilation of entire slirp directory for Xen. Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|