From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KGsls-0005Bg-FW
	for qemu-devel@nongnu.org; Thu, 10 Jul 2008 05:49:04 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KGslo-0005Ao-8B
	for qemu-devel@nongnu.org; Thu, 10 Jul 2008 05:49:01 -0400
Received: from [199.232.76.173] (port=34456 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KGslm-0005AG-W6
	for qemu-devel@nongnu.org; Thu, 10 Jul 2008 05:48:59 -0400
Received: from relay01.mx.bawue.net ([193.7.176.67]:59872)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <ths@networkno.de>) id 1KGsll-00024g-QX
	for qemu-devel@nongnu.org; Thu, 10 Jul 2008 05:48:58 -0400
Date: Thu, 10 Jul 2008 10:48:53 +0100
From: Thiemo Seufer <ths@networkno.de>
Subject: Re: [Qemu-devel] SH4 TARGET_NR_clone
Message-ID: <20080710094853.GA4303@networkno.de>
References: <4875D472.5020807@gandalf.sssup.it>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4875D472.5020807@gandalf.sssup.it>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: michael <trimarchi@gandalf.sssup.it>
Cc: qemu-devel@nongnu.org

michael wrote:
> Hi,
>
> This patch fix the call of Clone in SH4 system

What exactly does it fix? The kernel side of sys_clone seems to be no
different to other architectures.


Thiemo


> This patch implements the correct TARGET_NR_clone for SH4
> cpu.
> 
> Signed-off-by: Michael Trimarchi <trimarchimichael@yahoo.it>
> 
> Index: linux-user/syscall.c
> ===================================================================
> --- linux-user/syscall.c	(revision 4865)
> +++ linux-user/syscall.c	(working copy)
> @@ -53,6 +53,7 @@
>  //#include <sys/user.h>
>  #include <netinet/ip.h>
>  #include <netinet/tcp.h>
> +#include <qemu-common.h>
>  
>  #define termios host_termios
>  #define winsize host_winsize
> @@ -4657,7 +4658,11 @@
>          ret = get_errno(fsync(arg1));
>          break;
>      case TARGET_NR_clone:
> +#if !defined(TARGET_SH4)
>          ret = get_errno(do_fork(cpu_env, arg1, arg2, arg3, arg4, arg5));
> +#else
> +        ret = get_errno(do_fork(cpu_env, arg1, arg2, arg3, arg5, arg4));
> +#endif
>          break;
>  #ifdef __NR_exit_group
>          /* new thread calls */