All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Robert Richter <robert.richter@amd.com>
Cc: Ingo Molnar <mingo@redhat.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: x86/pci: Broken build for X86_VISWS
Date: Thu, 10 Jul 2008 12:38:31 +0200	[thread overview]
Message-ID: <20080710103831.GA30650@elte.hu> (raw)
In-Reply-To: <20080710102305.GA20096@elte.hu>


* Ingo Molnar <mingo@elte.hu> wrote:

> * Robert Richter <robert.richter@amd.com> wrote:
> 
> > Ingo,
> > 
> > during testing of my pci changes I observed a build error if X86_VISWS 
> > is set:
> > 
> > arch/x86/mach-visws/built-in.o: In function `machine_power_off':
> > (.text+0x48): undefined reference to `pci_bus0'
> > make[1]: *** [.tmp_vmlinux1] Error 1
> > make: *** [sub-make] Error 2
> > 
> > The root cause is disabling PCI dependencies in change 1ac97018 that 
> > disables compilation of x86/pci for VISWS though there are files in 
> > needed to build. I am not sure if it is save to enable PCI for VISWS 
> > to fix this.
> > 
> > Could you take a look at this?
> 
> well spotted. Does the patch below fix it for you?

there's another visws build bug related to generic-ipi - i fixed that in 
tip/master.

	Ingo

  reply	other threads:[~2008-07-10 10:38 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-10  9:57 x86/pci: Broken build for X86_VISWS Robert Richter
2008-07-10 10:19 ` [PATCH] x86/pci: Fix build error " Robert Richter
2008-07-10 10:23 ` x86/pci: Broken build " Ingo Molnar
2008-07-10 10:38   ` Ingo Molnar [this message]
2008-07-10 10:42   ` Robert Richter
2008-07-10 10:44     ` Ingo Molnar
2008-07-10 10:57       ` Robert Richter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080710103831.GA30650@elte.hu \
    --to=mingo@elte.hu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=robert.richter@amd.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.